From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#18175: files.el: use mapc in (mapcar 'switch-to-buffer ...) Date: Thu, 07 Aug 2014 15:29:03 -0400 Message-ID: References: <87r40yftes.fsf@violet.siamics.net> <87ha1ot8kp.fsf@violet.siamics.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1407439832 10197 80.91.229.3 (7 Aug 2014 19:30:32 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 7 Aug 2014 19:30:32 +0000 (UTC) Cc: 18175@debbugs.gnu.org To: Ivan Shmakov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Aug 07 21:30:22 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XFTOH-0000Yb-Sg for geb-bug-gnu-emacs@m.gmane.org; Thu, 07 Aug 2014 21:30:21 +0200 Original-Received: from localhost ([::1]:47923 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XFTOH-0000FM-1f for geb-bug-gnu-emacs@m.gmane.org; Thu, 07 Aug 2014 15:30:21 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50979) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XFTO7-0000E4-6P for bug-gnu-emacs@gnu.org; Thu, 07 Aug 2014 15:30:18 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XFTNz-0004Vg-Nw for bug-gnu-emacs@gnu.org; Thu, 07 Aug 2014 15:30:11 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:55590) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XFTNz-0004VK-Lo for bug-gnu-emacs@gnu.org; Thu, 07 Aug 2014 15:30:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XFTNz-0006yp-7D for bug-gnu-emacs@gnu.org; Thu, 07 Aug 2014 15:30:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 07 Aug 2014 19:30:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18175 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: wontfix Original-Received: via spool by 18175-submit@debbugs.gnu.org id=B18175.140743975326739 (code B ref 18175); Thu, 07 Aug 2014 19:30:03 +0000 Original-Received: (at 18175) by debbugs.gnu.org; 7 Aug 2014 19:29:13 +0000 Original-Received: from localhost ([127.0.0.1]:34300 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XFTNA-0006xC-LX for submit@debbugs.gnu.org; Thu, 07 Aug 2014 15:29:13 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:26978) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XFTN7-0006wy-PJ for 18175@debbugs.gnu.org; Thu, 07 Aug 2014 15:29:10 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ArYGAIDvNVPAqyKr/2dsb2JhbABZgwaDSlK/a4EXF3SCJQEBAQECASMzIwULCxoCGA4CAhQYDSSIBAivG6J+F4EpjR4zB4JvgUkEqwODTCE X-IPAS-Result: ArYGAIDvNVPAqyKr/2dsb2JhbABZgwaDSlK/a4EXF3SCJQEBAQECASMzIwULCxoCGA4CAhQYDSSIBAivG6J+F4EpjR4zB4JvgUkEqwODTCE X-IronPort-AV: E=Sophos;i="4.97,753,1389762000"; d="scan'208";a="82403315" Original-Received: from 192-171-34-171.cpe.pppoe.ca (HELO pastel.home) ([192.171.34.171]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 07 Aug 2014 15:29:04 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id CCB4867923; Thu, 7 Aug 2014 15:29:03 -0400 (EDT) In-Reply-To: <87ha1ot8kp.fsf@violet.siamics.net> (Ivan Shmakov's message of "Thu, 07 Aug 2014 19:15:34 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:92281 Archived-At: > I tend to disagree with that last part, =E2=80=93 it seems like a common > idiom for a function (or, generally, =E2=80=93 a /form/; setq does that, > for one thing) that=E2=80=99s used =E2=80=9Csolely=E2=80=9D for its side= -effects to > return its =E2=80=9Cprimary=E2=80=9D argument, thus allowing for easy Yes, it's common, but I strongly dislike it. It's used often enough for `setq' that I consider it to be an exception. In the case of `mapc' OTOH, I'm pretty sure 99.9% of Elisp coders have no idea what is the return value of `mapc', so using this return value is a kind of obfuscation. > Yes. However, I believe that the last two hunks of the one > another variant of the diff (MIMEd) actually make the intent to > return the reverse of the list returned by find-file-noselect > /clearer,/ =E2=80=93 although at the expense of adding one extra LoC in > each case. Agreed, and neither relies on the return value of `mapc', so those two hunks are indeed good. Please install them. Stefan