From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#1092: compilation-goto-error goes to wrong location when buffer has hidden regions Date: Mon, 04 Jan 2016 23:12:29 -0500 Message-ID: References: <48E90990.1020101@gmail.com> <83k2nqadd0.fsf@gnu.org> <8360zaa9l2.fsf@gnu.org> <83mvsm8mvc.fsf@gnu.org> <83ziwl73no.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1451967206 32387 80.91.229.3 (5 Jan 2016 04:13:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 5 Jan 2016 04:13:26 +0000 (UTC) Cc: ahyatt@gmail.com, 1092@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jan 05 05:13:15 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aGIzi-0007V5-LX for geb-bug-gnu-emacs@m.gmane.org; Tue, 05 Jan 2016 05:13:14 +0100 Original-Received: from localhost ([::1]:48010 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aGIze-0000eN-Ht for geb-bug-gnu-emacs@m.gmane.org; Mon, 04 Jan 2016 23:13:10 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46010) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aGIzZ-0000eF-Sv for bug-gnu-emacs@gnu.org; Mon, 04 Jan 2016 23:13:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aGIzW-00021A-N0 for bug-gnu-emacs@gnu.org; Mon, 04 Jan 2016 23:13:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:49831) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aGIzW-000216-JL for bug-gnu-emacs@gnu.org; Mon, 04 Jan 2016 23:13:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84) (envelope-from ) id 1aGIzW-0008Ed-Fz for bug-gnu-emacs@gnu.org; Mon, 04 Jan 2016 23:13:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 05 Jan 2016 04:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 1092 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: wontfix Original-Received: via spool by 1092-submit@debbugs.gnu.org id=B1092.145196715631617 (code B ref 1092); Tue, 05 Jan 2016 04:13:02 +0000 Original-Received: (at 1092) by debbugs.gnu.org; 5 Jan 2016 04:12:36 +0000 Original-Received: from localhost ([127.0.0.1]:38051 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aGIz6-0008Ds-2P for submit@debbugs.gnu.org; Mon, 04 Jan 2016 23:12:36 -0500 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:55672) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aGIz4-0008Dl-E5 for 1092@debbugs.gnu.org; Mon, 04 Jan 2016 23:12:35 -0500 Original-Received: from fmsmemgm.homelinux.net (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id u054CT0L003104; Mon, 4 Jan 2016 23:12:30 -0500 Original-Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 3A4F5AE09F; Mon, 4 Jan 2016 23:12:29 -0500 (EST) In-Reply-To: <83ziwl73no.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 04 Jan 2016 17:41:47 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV5540=0 X-NAI-Spam-Version: 2.3.0.9418 : core <5540> : inlines <4176> : streams <1565629> : uri <2114368> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:111225 Archived-At: > Setting a variable is a user-level feature. I've never ever heard of a user setting selective-display manually to t. It's always done from some Elisp package. And it's no wonder: setting selective-display=t has about zero effect. It only starts to do something when you start turning \n into \r (which is also when the problems start to come up). >> >> For the selective-display=t case, we have had replacement features in >> >> place and in wide use for what, twenty years? >> > Which replacements are those? I mean user commands or settings, not >> > infrastructure on which to base them. >> selective-display=t gives no user command, so I have no idea what you're >> expecting as "user command" to replace it. > And I did mean _both_ uses of selective-display, not only that single > one. As you can see above in the text you quoted, I was specifically referring to the selective-display=t case. > If and when there are replacements for both of them, we can > declare the variable obsolete and perhaps also remove its current > handling from the sources, if the replacement features allow to > emulate the variable's effect. The problem is that nobody really cares about the non-t part of selective-display: it doesn't cause any serious problems (contrary to the use of \r for "kind of end-of-line" in selective-display=t which requires special handling all over the place), isn't use very widely either, and is only a user-level feature (I don't know of any Elisp package making use of it). >> There are almost no uses of selective-display=t around, they've >> almost all been replaced by uses of overlays. > We have no idea of how many uses of this are out there. Of course we do have some idea. > We only know what's in Emacs and in ELPA, which is just a fraction of > what's out there. If you never look further than those, I hope you're an exception. I have a fairly extensive list of random packages I've bumped into over the years. And I can even tell you why there are very few uses of selective-display=t left: because it's a pain in the rear to use and is very limited. It's much simpler and more flexible to use overlays, so most packages have been rewritten over time to use overlays instead. >> >> We can very definitely declare this use case obsolete >> > We already did. And look how well did it serve us. >> Which problem did its obsolescence cause? > This one, for example. How did declaring the feature obsolete cause this bug? AFAICT this bug has been around since long before we declared the feature obsolete. > More importantly, it didn't resolve any problem. Declaring a feature obsolete doesn't resolve any problem. It just expresses our intent not to resolve those problems. > Anyway, I don't see where this discussion is going. The original bug > is fixed and closed. If you or someone else have a patch to replace > selective-display with alternative user features, let's see those > patches (preferably in another thread). Again, I have no clue what kind of user feature you're expecting. selective-display=t is 100% obsolete, with overlays as replacements available for so many years it's not even funny. My only intention in this discussion is to try and saves us from someone else ever trying to "fix" such bugs like you did. Instead we should always reply with something like "if it hurts when you use selective-display=t, then don't use it". Same applies for any other obsoleted feature. Stefan