From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#27986: 26.0.50; 'rename-file' can rename files without confirmation Date: Wed, 16 Aug 2017 18:31:14 -0400 Message-ID: References: <61980dde-3d68-7200-e7f4-98f62e410060@cs.ucla.edu> <1002ee73-0ab5-409b-831f-0c283c322264@cs.ucla.edu> <83o9rignt6.fsf@gnu.org> <83d17whl72.fsf@gnu.org> <8e6de468-600c-4f2d-a21a-c2ff3a63d065@cs.ucla.edu> <83zib0g221.fsf@gnu.org> <2bb4b7ee-6bf9-df3d-5cd8-ae7992b9f2e7@cs.ucla.edu> <83wp64fdc4.fsf@gnu.org> <83valnfv9u.fsf@gnu.org> <7f0c12f6-57eb-63b9-c296-e062cbf0710c@cs.ucla.edu> <83o9rffqfp.fsf@gnu.org> <83efsbfmij.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1502922730 28684 195.159.176.226 (16 Aug 2017 22:32:10 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 16 Aug 2017 22:32:10 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: p.stephani2@gmail.com, 27986@debbugs.gnu.org, rms@gnu.org, John Wiegley , Paul Eggert To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Aug 17 00:32:05 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1di6r6-00076f-QG for geb-bug-gnu-emacs@m.gmane.org; Thu, 17 Aug 2017 00:32:04 +0200 Original-Received: from localhost ([::1]:57111 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1di6rC-0005Bc-Uy for geb-bug-gnu-emacs@m.gmane.org; Wed, 16 Aug 2017 18:32:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49663) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1di6r6-0005AU-WD for bug-gnu-emacs@gnu.org; Wed, 16 Aug 2017 18:32:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1di6r3-0008RF-Rp for bug-gnu-emacs@gnu.org; Wed, 16 Aug 2017 18:32:04 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:32973) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1di6r3-0008R4-Ok for bug-gnu-emacs@gnu.org; Wed, 16 Aug 2017 18:32:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1di6r3-0007K1-I4 for bug-gnu-emacs@gnu.org; Wed, 16 Aug 2017 18:32:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 16 Aug 2017 22:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27986 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: security Original-Received: via spool by 27986-submit@debbugs.gnu.org id=B27986.150292269528111 (code B ref 27986); Wed, 16 Aug 2017 22:32:01 +0000 Original-Received: (at 27986) by debbugs.gnu.org; 16 Aug 2017 22:31:35 +0000 Original-Received: from localhost ([127.0.0.1]:41654 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1di6qc-0007JK-Of for submit@debbugs.gnu.org; Wed, 16 Aug 2017 18:31:34 -0400 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:51851) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1di6qZ-0007JB-TQ for 27986@debbugs.gnu.org; Wed, 16 Aug 2017 18:31:32 -0400 Original-Received: from ceviche.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id v7GMVEgT019303; Wed, 16 Aug 2017 18:31:16 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id 46BDE66334; Wed, 16 Aug 2017 18:31:14 -0400 (EDT) In-Reply-To: <83efsbfmij.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 16 Aug 2017 20:30:44 +0300") X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV6095=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6095> : inlines <6024> : streams <1758894> : uri <2484405> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:135846 Archived-At: >> This should be quite rare. The only scenario I see matching your >> concern is if the source is a directory, the destination is not >> a directory name but is an empty directory and is not a symlink, and >> the destination is not a descendant of the source. Although not >> impossible, this will happen so rarely that it doesn't invalidate >> the proposed change. Paul's suggestion makes a lot of sense to me, but I don't quite understand the above: why does the emptiness of the destination directory matter? Stefan