From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#22983: [ Patch ] Re: bug#22983: syntax-ppss returns wrong result. Date: Mon, 11 Sep 2017 07:10:50 -0400 Message-ID: References: <9fc66395-045c-1984-f530-033c2ff706f6@yandex.ru> <83h8wlz1kf.fsf@gnu.org> <20170902174027.GB4267@ACM> <20170907204502.GC4488@ACM> <69e034d3-7a52-cc81-dc56-e5308ad5dce0@yandex.ru> <20170910113626.GB3588@ACM> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1505130337 11819 195.159.176.226 (11 Sep 2017 11:45:37 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 11 Sep 2017 11:45:37 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: Alan Mackenzie , Philipp Stephani , John Wiegley , 22983@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Sep 11 13:45:26 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1drN9K-0001wR-Qb for geb-bug-gnu-emacs@m.gmane.org; Mon, 11 Sep 2017 13:45:10 +0200 Original-Received: from localhost ([::1]:56940 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1drN9R-0005E8-Vk for geb-bug-gnu-emacs@m.gmane.org; Mon, 11 Sep 2017 07:45:18 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44678) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1drMcM-0000SL-Li for bug-gnu-emacs@gnu.org; Mon, 11 Sep 2017 07:11:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1drMcI-0000Zi-LB for bug-gnu-emacs@gnu.org; Mon, 11 Sep 2017 07:11:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:51904) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1drMcI-0000Zc-Ho for bug-gnu-emacs@gnu.org; Mon, 11 Sep 2017 07:11:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1drMcI-0006UM-Cs for bug-gnu-emacs@gnu.org; Mon, 11 Sep 2017 07:11:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 11 Sep 2017 11:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22983 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 22983-submit@debbugs.gnu.org id=B22983.150512825424921 (code B ref 22983); Mon, 11 Sep 2017 11:11:02 +0000 Original-Received: (at 22983) by debbugs.gnu.org; 11 Sep 2017 11:10:54 +0000 Original-Received: from localhost ([127.0.0.1]:60585 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1drMc9-0006Tt-Sn for submit@debbugs.gnu.org; Mon, 11 Sep 2017 07:10:54 -0400 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:56173) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1drMc8-0006Tl-BC for 22983@debbugs.gnu.org; Mon, 11 Sep 2017 07:10:53 -0400 Original-Received: from ceviche.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id v8BBAoJd015958; Mon, 11 Sep 2017 07:10:51 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id 8D23E66257; Mon, 11 Sep 2017 07:10:50 -0400 (EDT) In-Reply-To: (Dmitry Gutov's message of "Mon, 11 Sep 2017 02:36:53 +0300") X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV6112=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6112> : inlines <6061> : streams <1762538> : uri <2498582> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:136773 Archived-At: >> I think that (parse-partial-sexp 1 x) is more often what the caller >> wants than (parse-partial-sexp (point-min) x), but if you're happy with >> the behavior described by the docstring, then that's fine. > And yet, I struggle to find such callers. But those that do, can > (save-restriction (widen) (syntax-ppss)) anyway. Good point. >>> +;; The implementation which follows uses three caches, the current one >>> +;; (in `syntax-ppss-cache' and `syntax-ppss-last') and two inactive >>> +;; ones (in `syntax-ppss-{cache,last}-{wide,narrow}'), which store the >>> +;; former state of the active cache as it was used in widened and >>> +;; narrowed buffers respectively. >> Earlier in the thread, I suggested to use a single cache indexed by the >> position of point-min > That would lead to clobbering the global cache when we use syntax-ppss for > some local parsing. My suggestion is to have a list of N caches, instead of having exactly 2 caches. I can't see how that could lead to more clobbering. > I'm considering the idea now that syntax-ppss should stay a caching wrapper > around parse-partial-sexp, and the responsibility to widen should always be > the caller's. This way, it can be used for different purposes that we've > discussed before many times. It does have the advantage of circumventing the discussion of "up-to-where should we widen" ;-) Stefan