From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#34513: display-line-numbers in term mode Date: Wed, 27 Feb 2019 11:40:04 -0500 Message-ID: References: <20190217141940.62v754v46qwfcs2i@Ergus> <83h8cpkyi8.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="64703"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 34513@debbugs.gnu.org, spacibba@aol.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Feb 27 17:41:22 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gz2Gk-000Gau-7k for geb-bug-gnu-emacs@m.gmane.org; Wed, 27 Feb 2019 17:41:18 +0100 Original-Received: from localhost ([127.0.0.1]:47116 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gz2Gj-0001LV-AY for geb-bug-gnu-emacs@m.gmane.org; Wed, 27 Feb 2019 11:41:17 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:41880) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gz2Gd-0001L4-13 for bug-gnu-emacs@gnu.org; Wed, 27 Feb 2019 11:41:11 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gz2GY-000712-K6 for bug-gnu-emacs@gnu.org; Wed, 27 Feb 2019 11:41:07 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40695) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gz2GT-0006z3-NC for bug-gnu-emacs@gnu.org; Wed, 27 Feb 2019 11:41:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gz2GT-0004Za-JY for bug-gnu-emacs@gnu.org; Wed, 27 Feb 2019 11:41:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 27 Feb 2019 16:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34513 X-GNU-PR-Package: emacs Original-Received: via spool by 34513-submit@debbugs.gnu.org id=B34513.155128561317515 (code B ref 34513); Wed, 27 Feb 2019 16:41:01 +0000 Original-Received: (at 34513) by debbugs.gnu.org; 27 Feb 2019 16:40:13 +0000 Original-Received: from localhost ([127.0.0.1]:54239 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gz2Fh-0004YQ-4f for submit@debbugs.gnu.org; Wed, 27 Feb 2019 11:40:13 -0500 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:35843) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gz2Fe-0004YH-EX for 34513@debbugs.gnu.org; Wed, 27 Feb 2019 11:40:11 -0500 Original-Received: from fmsmemgm.homelinux.net (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id x1RGe4dl000632; Wed, 27 Feb 2019 11:40:04 -0500 Original-Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 733E3AE0E9; Wed, 27 Feb 2019 11:40:04 -0500 (EST) In-Reply-To: <83h8cpkyi8.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 27 Feb 2019 18:05:35 +0200") X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV6492=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6492> : inlines <7024> : streams <1814266> : uri <2803160> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:155857 Archived-At: >> PS: Why is the function called `line-number-display-width` when >> everything else seems to use the `display-line-number` prefix? > Because display-line-numbers-line-number-display-width is a mouthful > that I couldn't live with, and also repeats 3 words twice each. That would be awful, indeed. How 'bout display-line-numbers-width or display-line-numbers-current-width? >> - (ncols (/ window-width font-width))) >> + (ncols (- (/ window-width font-width) (line-number-display-width)))) > I think you want (line-number-display-width 'columns), since this > wants the canonical column units, right? Could be, I don't know. I don't know that all callers of window-max-chars-per-line want that either. Stefan