From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#35381: 26.2; nxml-mode doesn't fontify attributes in single quotes Date: Sun, 05 May 2019 09:06:33 -0400 Message-ID: References: <87imv6rpig.fsf@gmail.com> <87v9z4qjit.fsf@gmail.com> <87mukerfd2.fsf@gmail.com> <87ftq5q9xa.fsf@gmail.com> <87pnoxmubz.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="268772"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 35381@debbugs.gnu.org To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun May 05 15:07:10 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hNGrG-0017me-L6 for geb-bug-gnu-emacs@m.gmane.org; Sun, 05 May 2019 15:07:10 +0200 Original-Received: from localhost ([127.0.0.1]:40927 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hNGrF-0001NI-4T for geb-bug-gnu-emacs@m.gmane.org; Sun, 05 May 2019 09:07:09 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:46280) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hNGr9-0001ND-8G for bug-gnu-emacs@gnu.org; Sun, 05 May 2019 09:07:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hNGr8-000726-Ac for bug-gnu-emacs@gnu.org; Sun, 05 May 2019 09:07:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39673) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hNGr8-00071q-6w for bug-gnu-emacs@gnu.org; Sun, 05 May 2019 09:07:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hNGr7-0001WA-Vs for bug-gnu-emacs@gnu.org; Sun, 05 May 2019 09:07:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 05 May 2019 13:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35381 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 35381-submit@debbugs.gnu.org id=B35381.15570615975804 (code B ref 35381); Sun, 05 May 2019 13:07:01 +0000 Original-Received: (at 35381) by debbugs.gnu.org; 5 May 2019 13:06:37 +0000 Original-Received: from localhost ([127.0.0.1]:53217 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hNGqj-0001VY-3e for submit@debbugs.gnu.org; Sun, 05 May 2019 09:06:37 -0400 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:36261) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hNGqh-0001VP-48 for 35381@debbugs.gnu.org; Sun, 05 May 2019 09:06:36 -0400 Original-Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id x45D6XB9020547; Sun, 5 May 2019 09:06:34 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 99AD76A7EB; Sun, 5 May 2019 09:06:33 -0400 (EDT) In-Reply-To: <87pnoxmubz.fsf@gmail.com> (Noam Postavsky's message of "Sat, 04 May 2019 23:52:16 -0400") X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV6539=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6539> : inlines <7072> : streams <1820642> : uri <2840803> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:158791 Archived-At: > I think that plus the patches for #32003 and #32897 should cover the > nxml fixes I'm planning for emacs-26. I'll wait for another few days > and then push. LGTM. > https://debbugs.gnu.org/cgi/bugreport.cgi?filename=0001-Fix-nxml-get-inside-Bug-32003.patch;bug=32003;msg=8;att=1 You might like to mention in nxml-get-inside what "normal strings" are used for (AFAIK that's used exclusively for attributes). > https://debbugs.gnu.org/cgi/bugreport.cgi?filename=0001-Disable-extra-display-of-10-in-nxml-mode-Bug-32897.patch;att=1;msg=8;bug=32897 - (when nxml-char-ref-extra-display + (when (and ;; Displaying literal newline is unhelpful. + (not eql n ?\n) + nxml-char-ref-extra-display) There's a bunch of parens missing. Stefan