From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#47150: [External] : bug#47150: 28.0.50; Incorrect major-mode in minibuffer Date: Mon, 19 Apr 2021 16:36:35 -0400 Message-ID: References: <8cbe7629-2091-45d3-9424-46444d7a4633@www.fastmail.com> <887bda9c-906c-4163-a8db-08b45e021bfd@www.fastmail.com> <4e10120a-58e8-4813-bc3d-975ecd19ad75@www.fastmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4836"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: "47150@debbugs.gnu.org" <47150@debbugs.gnu.org>, Alan Mackenzie To: "Sheng Yang" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Apr 19 22:48:30 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lYaom-00015Q-Bg for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 19 Apr 2021 22:48:28 +0200 Original-Received: from localhost ([::1]:33564 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lYaol-0001NS-Dg for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 19 Apr 2021 16:48:27 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37174) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lYadi-0004Wp-89 for bug-gnu-emacs@gnu.org; Mon, 19 Apr 2021 16:37:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40668) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lYadh-0008NM-SK for bug-gnu-emacs@gnu.org; Mon, 19 Apr 2021 16:37:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lYadh-000507-Nz for bug-gnu-emacs@gnu.org; Mon, 19 Apr 2021 16:37:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 19 Apr 2021 20:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47150 X-GNU-PR-Package: emacs Original-Received: via spool by 47150-submit@debbugs.gnu.org id=B47150.161886460519201 (code B ref 47150); Mon, 19 Apr 2021 20:37:01 +0000 Original-Received: (at 47150) by debbugs.gnu.org; 19 Apr 2021 20:36:45 +0000 Original-Received: from localhost ([127.0.0.1]:52214 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lYadQ-0004zc-Vc for submit@debbugs.gnu.org; Mon, 19 Apr 2021 16:36:45 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:7327) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lYadP-0004zR-Qv for 47150@debbugs.gnu.org; Mon, 19 Apr 2021 16:36:44 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 1635280A77; Mon, 19 Apr 2021 16:36:38 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 8C6138078F; Mon, 19 Apr 2021 16:36:36 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1618864596; bh=v7HomFPyPZfjBwmfq92V+c4w0Kn+UNFoG1C/cFum07o=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=IjoP1NNG7GWxWqnl/eTCOgUAIkgHBHJkQ8hCe1UQvuCEk37bu5chwUC87gWc4oZA0 xldWCUSjcRtH2dpH7DzzwmcqD+4YJlF/oU3zOxvOmf7DOM9zoywMGqWJhIh32y/dVD gNBwOK1mK+B/6y2Gv6j+QPWnfNAdzEt/Qp/8QuoiBpxtJwetujgiaBpJYI6EbuUz8g FWrWgOqxzIlyHGERC+2E9QNkSzsBv8qeAaWbjWSvBm7TnC8Sv0S0gP38SLcpZ2bsfY MOYajpuyMj1ItA+9fJMB4/3+E0Uy2FTvF+/yNxHfdjOAc0JKisN0KYLM8KPQXYMTr0 prlfIHRvP3K6A== Original-Received: from alfajor (104-222-126-84.cpe.teksavvy.com [104.222.126.84]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 51CEB1202C5; Mon, 19 Apr 2021 16:36:36 -0400 (EDT) In-Reply-To: <4e10120a-58e8-4813-bc3d-975ecd19ad75@www.fastmail.com> (Sheng Yang's message of "Mon, 19 Apr 2021 14:47:20 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:204507 Archived-At: > For telega, the check for minibuffer is a simple cl-assert, and I think your > suggestion of using `minibufferp` would be a better choice. Indeed. > For others, their test of minibuffer-inactive-mode is actually buried in > some variable `xxx-ignore-mode-list`, which is later checked by `(member > major-mode xxx-ignore-modes-list)`. My current modification is to add > `minibuffer-mode` to those variables. I assume this is the > simplest solution? Probably, tho it depends why they make this test. (e.g. in `smartparens`, I think it'd make a lot of sense to enable the minor mode during `M-:`, so it shouldn't be disabled for all minibuffers). Stefan