From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#51173: 28.0.60; gnus-article-describe-key doesn't work Date: Mon, 29 Nov 2021 15:57:51 -0500 Message-ID: References: <87h7dl6spg.fsf@gnus.org> <87r1cox4th.fsf@mail.linkov.net> <87h7dkx2g5.fsf@mail.linkov.net> <87r1cm3hqb.fsf@mail.linkov.net> <87h7dgg8go.fsf@mail.linkov.net> <87ilxumi07.fsf@mail.linkov.net> <87sfwvy411.fsf@mail.linkov.net> <86o862re53.fsf@mail.linkov.net> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22046"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 51173@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Nov 29 22:05:08 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mrnpk-0005SW-Kq for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 29 Nov 2021 22:05:08 +0100 Original-Received: from localhost ([::1]:40620 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mrnpj-0000ql-Np for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 29 Nov 2021 16:05:07 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:58286) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mrnjq-0007cD-ML for bug-gnu-emacs@gnu.org; Mon, 29 Nov 2021 15:59:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56285) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mrnjq-0007Bw-Dz for bug-gnu-emacs@gnu.org; Mon, 29 Nov 2021 15:59:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mrnjq-0001Vk-7a; Mon, 29 Nov 2021 15:59:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, bugs@gnus.org Resent-Date: Mon, 29 Nov 2021 20:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51173 X-GNU-PR-Package: emacs,gnus Original-Received: via spool by 51173-submit@debbugs.gnu.org id=B51173.16382194825741 (code B ref 51173); Mon, 29 Nov 2021 20:59:02 +0000 Original-Received: (at 51173) by debbugs.gnu.org; 29 Nov 2021 20:58:02 +0000 Original-Received: from localhost ([127.0.0.1]:39597 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mrnis-0001UX-GT for submit@debbugs.gnu.org; Mon, 29 Nov 2021 15:58:02 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:23415) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mrniq-0001U2-Jq for 51173@debbugs.gnu.org; Mon, 29 Nov 2021 15:58:01 -0500 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 6D05444106B; Mon, 29 Nov 2021 15:57:54 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 0CFA3441069; Mon, 29 Nov 2021 15:57:53 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1638219473; bh=I/RnE+mSiHOnH8KI1Cmr5nIy+TVXgIBgoHcOlnHdKfc=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=IqxZbcmjf8aL0ezx4i8xOq/e0Euc1RjFZwQDXCaWNAridTVqF0dMUoHJGjM+ytVVD c2AN4gC86qL2ZnTHE2wpu6MCBc9wbEqoINAZ6sKmil2wUkckbAP9PBjaRZ9IBs85Ca 2iLtTjMRbu3A6dHuHnaJ8V78XJrrj7QxSlTxW9d8eLQFMdUcZOo3soC0n+r7+bN3Vf /GBGhb1YCqJDFYEGB2d/mSsjqWj0P8UMa17NIVy/7JjSoTA/5jO3t9+CKDOW14lCqJ KxnRdwXjYgvHnJy0PThnSAefFq3uFsGwbs4dPck4OXDSFjWv3KUp8akKZUkNpxZziK nN+gqeIOJg+EQ== Original-Received: from milanesa (unknown [24.48.75.95]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id CCE70120797; Mon, 29 Nov 2021 15:57:52 -0500 (EST) In-Reply-To: <86o862re53.fsf@mail.linkov.net> (Juri Linkov's message of "Mon, 29 Nov 2021 20:49:12 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:221089 Archived-At: > mouse-minibuffer-check(19) > mouse-set-point(19) > help--analyze-key("\23" [19] nil) Hpw 'bout the patch below? Or maybe the use of `mouse-minibuffer-check` in `mouse-set-point` should be moved to its interactive spec? Stefan diff --git a/lisp/help.el b/lisp/help.el index 1917ef425d..e175421d02 100644 --- a/lisp/help.el +++ b/lisp/help.el @@ -715,7 +715,8 @@ help--analyze-key (and (not (windowp (posn-window (event-start event)))) (not (framep (posn-window (event-start event)))))) (key-binding key t) - (save-excursion (mouse-set-point event) (key-binding key t))))) + (save-excursion (posn-set-point (event-end event)) + (key-binding key t))))) ;; Handle the case where we faked an entry in "Select and Paste" menu. (when (and (eq defn nil) (stringp (aref key (1- (length key))))