From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#53153: package-quickstart: unusual autoload form in selectrum gives byte-compilation warning Date: Thu, 13 Jan 2022 09:46:21 -0500 Message-ID: References: Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17170"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 53153@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jan 13 15:48:27 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n81Or-00049s-Ji for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 13 Jan 2022 15:48:25 +0100 Original-Received: from localhost ([::1]:47080 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n81Oq-0006MM-3D for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 13 Jan 2022 09:48:24 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:43902) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n81NW-0005br-9y for bug-gnu-emacs@gnu.org; Thu, 13 Jan 2022 09:47:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39436) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n81NW-0001ZA-0r for bug-gnu-emacs@gnu.org; Thu, 13 Jan 2022 09:47:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n81NV-0003CL-RQ for bug-gnu-emacs@gnu.org; Thu, 13 Jan 2022 09:47:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 13 Jan 2022 14:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53153 X-GNU-PR-Package: emacs Original-Received: via spool by 53153-submit@debbugs.gnu.org id=B53153.164208519512250 (code B ref 53153); Thu, 13 Jan 2022 14:47:01 +0000 Original-Received: (at 53153) by debbugs.gnu.org; 13 Jan 2022 14:46:35 +0000 Original-Received: from localhost ([127.0.0.1]:60572 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n81N5-0003BW-GO for submit@debbugs.gnu.org; Thu, 13 Jan 2022 09:46:35 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:33262) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n81N1-0003BC-7r for 53153@debbugs.gnu.org; Thu, 13 Jan 2022 09:46:34 -0500 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id D85C5805CC; Thu, 13 Jan 2022 09:46:24 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 056D180306; Thu, 13 Jan 2022 09:46:23 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1642085183; bh=YEc49BrNZ++SbfhjjfUumjksZZu5J255ppPSaNffOiI=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=Ga5N57fMkZt9+cIcxSsUBSfMtyFI99QsPdZ2mDjFyCtClCs21Z6t5+Yk5nMyR25qV ktqu1wwV6rUV6QlqrQ0JljqBnFsPDNWZQN4bLAuKKiWzTaftWoA9f5KFa47VfNfT2c VJGaX4bn5FKndSexiDoeXBJcGsrXhc9P2PYK+ZvZQiYQ4MqyNrAR323DU1r1oI+ahH MhWr3KyZy9qpWq1StKIs4EMlceoSfoykNkFAfZIzyzHpApmN2e3c0+nbekbVimcAgQ QzxjrAcLnUWfRT2RwcJ9bdM5QLsjzgP8v/dE5P7LCatc005I9SeCBecXLKC5+qgd5T 2Gbm59jCs1fUA== Original-Received: from ceviche (unknown [216.154.30.173]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id D54DA120337; Thu, 13 Jan 2022 09:46:22 -0500 (EST) In-Reply-To: (Stefan Kangas's message of "Sun, 9 Jan 2022 22:46:59 -0600") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:224114 Archived-At: > This unusual arrangement means that we end up with this interesting form > in package-quickstart.el (pretty-printed): > > (define-minor-mode selectrum-mode > "Minor mode to use Selectrum for `completing-read'." > :global t > (if selectrum-mode (progn [...] Global minor modes define a `defcustom` and its :group is usually provided by default by the last `defgroup` but if you copy this `define-minor-mode` to some other file (such as an autoloads file), then you can't rely on this defaulting so you should provide a `:group` explicitly. Regarding using such a "trick" or placing the minor mode in its own file, both approaches have their advantages and disadvantages so while it's unusual I don't see a problem with it. Stefan