From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs,gmane.emacs.pretest.bugs Subject: bug#931: 23.0.60; Bug in bytecomp.el: displaying warnings Date: Tue, 09 Sep 2008 10:33:37 -0400 Message-ID: References: <1220902523.951243.11457@green> Reply-To: Stefan Monnier , 931@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1220971904 1811 80.91.229.12 (9 Sep 2008 14:51:44 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 9 Sep 2008 14:51:44 +0000 (UTC) Cc: 931@emacsbugs.donarmstrong.com, emacs-pretest-bug@gnu.org To: michael_heerdegen@web.de Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Sep 09 16:52:39 2008 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Kd4WO-0000BM-DG for geb-bug-gnu-emacs@m.gmane.org; Tue, 09 Sep 2008 16:48:48 +0200 Original-Received: from localhost ([127.0.0.1]:38533 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Kd4VN-0003eG-QO for geb-bug-gnu-emacs@m.gmane.org; Tue, 09 Sep 2008 10:47:45 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Kd4VJ-0003bv-51 for bug-gnu-emacs@gnu.org; Tue, 09 Sep 2008 10:47:41 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Kd4VG-0003a1-8d for bug-gnu-emacs@gnu.org; Tue, 09 Sep 2008 10:47:39 -0400 Original-Received: from [199.232.76.173] (port=37377 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Kd4VF-0003Yp-Lo for bug-gnu-emacs@gnu.org; Tue, 09 Sep 2008 10:47:37 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:55482) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Kd4VE-0007Iw-Il for bug-gnu-emacs@gnu.org; Tue, 09 Sep 2008 10:47:37 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m89ElWCs019248; Tue, 9 Sep 2008 07:47:33 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id m89Ee5DM016257; Tue, 9 Sep 2008 07:40:05 -0700 X-Loop: don@donarmstrong.com Resent-From: Stefan Monnier Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Tue, 09 Sep 2008 14:40:05 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 931 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by submit@emacsbugs.donarmstrong.com id=B.122097083714260 (code B ref -1); Tue, 09 Sep 2008 14:40:05 +0000 Original-Received: (at submit) by emacsbugs.donarmstrong.com; 9 Sep 2008 14:33:57 +0000 Original-Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m89EXkg1014250 for ; Tue, 9 Sep 2008 07:33:47 -0700 Original-Received: from mail.gnu.org ([199.232.76.166]:44446 helo=mx10.gnu.org) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1Kd4G7-0006vW-Qk for emacs-pretest-bug@gnu.org; Tue, 09 Sep 2008 10:31:59 -0400 Original-Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1Kd4Hj-0003CP-Mn for emacs-pretest-bug@gnu.org; Tue, 09 Sep 2008 10:33:44 -0400 Original-Received: from ironport2-out.pppoe.ca ([206.248.154.182]:61657 helo=ironport2-out.teksavvy.com) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Kd4Hj-0003Bw-9s for emacs-pretest-bug@gnu.org; Tue, 09 Sep 2008 10:33:39 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AsAEALEmxkhFxIqP/2dsb2JhbACBZbRXgWSBBw X-IronPort-AV: E=Sophos;i="4.32,365,1217822400"; d="scan'208";a="26559112" Original-Received: from 69-196-138-143.dsl.teksavvy.com (HELO pastel.home) ([69.196.138.143]) by ironport2-out.teksavvy.com with ESMTP; 09 Sep 2008 10:33:37 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id B4E8054279; Tue, 9 Sep 2008 10:33:37 -0400 (EDT) In-Reply-To: <1220902523.951243.11457@green> (Michael Heerdegen's message of "Mon, 8 Sep 2008 21:35:23 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. X-CrossAssassin-Score: 2 X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) Resent-Date: Tue, 09 Sep 2008 10:47:38 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:20393 gmane.emacs.pretest.bugs:23026 Archived-At: > If pop-up-windows is nil, and warnings have to be displayed, > `byte-compile-report-error' is called, and after that, > (current-buffer) will be the Compile Log buffer, and the current > buffer is not restored for further iterations of the while loop. Does the patch below fix the problem? Maybe the fix should even be pushed further down into display-buffer? Stefan === modified file 'lisp/emacs-lisp/warnings.el' --- lisp/emacs-lisp/warnings.el 2008-05-06 14:18:59 +0000 +++ lisp/emacs-lisp/warnings.el 2008-09-09 14:32:38 +0000 @@ -286,11 +286,15 @@ (or (< (warning-numeric-level level) (warning-numeric-level warning-minimum-level)) (warning-suppress-p type warning-suppress-types) + ;; `display-buffer' usually preserves current-buffer, except + ;; when it ends up doing switch-to-buffer (e.g. pop-up-windows + ;; is nil). + (save-current-buffer (let ((window (display-buffer buffer))) (when (and (markerp warning-series) (eq (marker-buffer warning-series) buffer)) (set-window-start window warning-series)) - (sit-for 0))))))) + (sit-for 0)))))))) ;;;###autoload (defun lwarn (type level message &rest args)