From: Stefan Monnier <monnier@iro.umontreal.ca>
To: michael_heerdegen@web.de
Cc: 931@emacsbugs.donarmstrong.com, emacs-pretest-bug@gnu.org
Subject: bug#931: 23.0.60; Bug in bytecomp.el: displaying warnings
Date: Tue, 09 Sep 2008 10:33:37 -0400 [thread overview]
Message-ID: <jwvhc8pgzq7.fsf-monnier+emacsbugreports@gnu.org> (raw)
In-Reply-To: <1220902523.951243.11457@green> (Michael Heerdegen's message of "Mon, 8 Sep 2008 21:35:23 +0200")
> If pop-up-windows is nil, and warnings have to be displayed,
> `byte-compile-report-error' is called, and after that,
> (current-buffer) will be the Compile Log buffer, and the current
> buffer is not restored for further iterations of the while loop.
Does the patch below fix the problem?
Maybe the fix should even be pushed further down into display-buffer?
Stefan
=== modified file 'lisp/emacs-lisp/warnings.el'
--- lisp/emacs-lisp/warnings.el 2008-05-06 14:18:59 +0000
+++ lisp/emacs-lisp/warnings.el 2008-09-09 14:32:38 +0000
@@ -286,11 +286,15 @@
(or (< (warning-numeric-level level)
(warning-numeric-level warning-minimum-level))
(warning-suppress-p type warning-suppress-types)
+ ;; `display-buffer' usually preserves current-buffer, except
+ ;; when it ends up doing switch-to-buffer (e.g. pop-up-windows
+ ;; is nil).
+ (save-current-buffer
(let ((window (display-buffer buffer)))
(when (and (markerp warning-series)
(eq (marker-buffer warning-series) buffer))
(set-window-start window warning-series))
- (sit-for 0)))))))
+ (sit-for 0))))))))
\f
;;;###autoload
(defun lwarn (type level message &rest args)
next prev parent reply other threads:[~2008-09-09 14:33 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <jwvljxxgn4j.fsf-monnier+emacsbugreports@gnu.org>
2008-09-08 19:35 ` bug#931: 23.0.60; Bug in bytecomp.el: displaying warnings Michael Heerdegen
2008-09-08 21:12 ` martin rudalics
2008-09-09 8:11 ` Richard M. Stallman
2008-09-10 9:23 ` martin rudalics
2008-09-10 20:46 ` Richard M. Stallman
2008-09-11 8:53 ` martin rudalics
2008-09-09 14:33 ` Stefan Monnier [this message]
2008-09-10 9:23 ` martin rudalics
2008-09-10 16:24 ` Stefan Monnier
2008-09-10 17:37 ` martin rudalics
2008-09-11 1:52 ` Stefan Monnier
2008-09-11 8:53 ` martin rudalics
2008-09-12 16:30 ` Stefan Monnier
2008-09-12 18:04 ` martin rudalics
2008-09-12 20:00 ` bug#931: marked as done (23.0.60; Bug in bytecomp.el: displaying warnings) Emacs bug Tracking System
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvhc8pgzq7.fsf-monnier+emacsbugreports@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=931@emacsbugs.donarmstrong.com \
--cc=emacs-pretest-bug@gnu.org \
--cc=michael_heerdegen@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).