From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#753: [Fwd: sh-script.el: indentation of ( )] Date: Thu, 08 Jan 2009 11:39:55 -0500 Message-ID: References: <48AC8E68.8080503@t-online.de> Reply-To: Stefan Monnier , 753@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1231434486 29216 80.91.229.12 (8 Jan 2009 17:08:06 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 8 Jan 2009 17:08:06 +0000 (UTC) Cc: 753@emacsbugs.donarmstrong.com To: Glenn Morris Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jan 08 18:09:17 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LKyNX-0005ZM-9N for geb-bug-gnu-emacs@m.gmane.org; Thu, 08 Jan 2009 18:09:07 +0100 Original-Received: from localhost ([127.0.0.1]:56729 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LKyMH-0005Wc-Gs for geb-bug-gnu-emacs@m.gmane.org; Thu, 08 Jan 2009 12:07:49 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LKyI5-0003YV-7y for bug-gnu-emacs@gnu.org; Thu, 08 Jan 2009 12:03:29 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LKyI3-0003XB-Rn for bug-gnu-emacs@gnu.org; Thu, 08 Jan 2009 12:03:28 -0500 Original-Received: from [199.232.76.173] (port=41917 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LKyI3-0003Wy-CC for bug-gnu-emacs@gnu.org; Thu, 08 Jan 2009 12:03:27 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:37183) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LKyI2-0005Bk-MZ for bug-gnu-emacs@gnu.org; Thu, 08 Jan 2009 12:03:26 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n08H3ONe026868; Thu, 8 Jan 2009 09:03:24 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id n08Go4D2023422; Thu, 8 Jan 2009 08:50:04 -0800 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Stefan Monnier Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Thu, 08 Jan 2009 16:50:04 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 753 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 753-submit@emacsbugs.donarmstrong.com id=B753.123143280621027 (code B ref 753); Thu, 08 Jan 2009 16:50:04 +0000 Original-Received: (at 753) by emacsbugs.donarmstrong.com; 8 Jan 2009 16:40:06 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from ironport2-out.teksavvy.com (ironport2-out.teksavvy.com [206.248.154.182]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n08Ge1Ie020788 for <753@emacsbugs.donarmstrong.com>; Thu, 8 Jan 2009 08:40:03 -0800 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AnQFAC+7ZUlFxJt//2dsb2JhbACBbM1UhXWBaQ X-IronPort-AV: E=Sophos;i="4.37,235,1231131600"; d="scan'208";a="32028323" Original-Received: from 69-196-155-127.dsl.teksavvy.com (HELO pastel.home) ([69.196.155.127]) by ironport2-out.teksavvy.com with ESMTP; 08 Jan 2009 11:39:56 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 0291C86E5; Thu, 8 Jan 2009 11:39:56 -0500 (EST) In-Reply-To: (Glenn Morris's message of "Thu, 08 Jan 2009 03:00:53 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Thu, 08 Jan 2009 12:03:27 -0500 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:23923 Archived-At: > [ You must unarchive old bugs before mailing them ] Yes: I didn't know it was old :-( >>> Can you remember why you added '()'? >> Because neither ( nor ) are allowed in keywords. > They _are_ keywords, along with { and }, as evidenced by their entries > in the constant `sh-kw'. Hmm... I think I see what might be the problem, tho I don't understand the code enough. Basically, what I saw is that it recognized "done|" as a keyword, which I fixed by adding ?| to the "not in keywords" chars. By the same reasonging "done)" is not a keyword, so I added ?\) (and ?\( as well for good measure). I guess that sh-get-kw should be fixed more robustly by recognizing ")" and "(" but not "(done", nor "(done|toto)" for that matter. Can you take care of that and make sure it fixes the problem at hand without breaking the problem that prompted my misguided fix? Stefan