bug#3410: tar mode fails to open many valid files

bug#3410: tar mode fails to open many valid files

[Paul Pogonyshev]

When I open a 'tar.gz' file in Emacs, it quite often fails with a
message similar to:

    File mode specification error: (error
    "ntWorkbookBuilder.SheetRecordCollectingListener.html\"
    title=\"class in org.apache.poi.hssf.eventuserm has size
    -137265917 - corrupted")

E.g. file at

    http://apache.promotionalpro.com/poi/dev/bin/poi-bin-3.5-beta5-20090219.tar.gz

exhibits this error.  It can be extracted without problems with 'tar
-xzf ...' at command line, so it must be a bug in Emacs' tar mode.
Maybe it is too strict or doesn't handle some extension properly.

Paul

bug#3410: tar mode fails to open many valid files

[Stefan Monnier]

> http://apache.promotionalpro.com/poi/dev/bin/poi-bin-3.5-beta5-20090219.tar.gz

> exhibits this error.

It opens just fine for me.  Are you using Emacs-22 rather than the
pretest, by any chance?


        Stefan

bug#3410: tar mode fails to open many valid files

[Paul Pogonyshev]

Stefan Monnier wrote:
> > http://apache.promotionalpro.com/poi/dev/bin/poi-bin-3.5-beta5-20090219.tar.gz
> 
> > exhibits this error.
> 
> It opens just fine for me.  Are you using Emacs-22 rather than the
> pretest, by any chance?

No, M-x version reports GNU Emacs 23.0.94.1 (i686-pc-linux-gnu, GTK+
Version 2.14.4).  Just checked, I get the error also with 'emacs -q'.

Paul

bug#3410: tar mode fails to open many valid files

[Stefan Monnier]

>> > http://apache.promotionalpro.com/poi/dev/bin/poi-bin-3.5-beta5-20090219.tar.gz
>> 
>> > exhibits this error.
>> 
>> It opens just fine for me.  Are you using Emacs-22 rather than the
>> pretest, by any chance?

> No, M-x version reports GNU Emacs 23.0.94.1 (i686-pc-linux-gnu, GTK+
> Version 2.14.4).  Just checked, I get the error also with 'emacs -q'.

I cannot reproduce it with "emacs -Q
~/tmp/poi-bin-3.5-beta5-20090219.tar.gz" (on amd64 with Gtk as well).
Other than the "-Q" vs "-q" (i.e. if you have some site-start.el or
default.el that could interfere) I can't think of anything that could
explain the difference.


        Stefan

bug#3410: tar mode fails to open many valid files

[Paul Pogonyshev]

Stefan Monnier wrote:
> >> > http://apache.promotionalpro.com/poi/dev/bin/poi-bin-3.5-beta5-20090219.tar.gz
> >> 
> >> > exhibits this error.
> >> 
> >> It opens just fine for me.  Are you using Emacs-22 rather than the
> >> pretest, by any chance?
> 
> > No, M-x version reports GNU Emacs 23.0.94.1 (i686-pc-linux-gnu, GTK+
> > Version 2.14.4).  Just checked, I get the error also with 'emacs -q'.
> 
> I cannot reproduce it with "emacs -Q
> ~/tmp/poi-bin-3.5-beta5-20090219.tar.gz" (on amd64 with Gtk as well).
> Other than the "-Q" vs "-q" (i.e. if you have some site-start.el or
> default.el that could interfere)

I tried with 'emacs -Q' and get the same result:

File poi-bin-3.5-beta5-20090219.tar.gz is large (19MB), really open? (y or n) 
uncompressing poi-bin-3.5-beta5-20090219.tar.gz...done
Parsing tar file...
File mode specification error: (error "ntWorkbookBuilder.SheetRecordCollectingListener.html\" title=\"class in org.apache.poi.hssf.eventuserm has size -137265917 - corrupted")

> I can't think of anything that could explain the difference.

The only difference can I see is CPU architecture: you have amd64, but
I have a 32-bit system.

Paul

bug#3410: tar mode fails to open many valid files

[Stefan Monnier]

> I tried with 'emacs -Q' and get the same result:

> File poi-bin-3.5-beta5-20090219.tar.gz is large (19MB), really open? (y or n) 
> uncompressing poi-bin-3.5-beta5-20090219.tar.gz...done
> Parsing tar file...

Same thing until here.

> File mode specification error: (error "ntWorkbookBuilder.SheetRecordCollectingListener.html\" title=\"class in org.apache.poi.hssf.eventuserm has size -137265917 - corrupted")

I believe I could now reproduce it, but only if I use url-handler-mode
and download the file directly from Emacs.

I.e. it works fine with
   emacs -Q ~/tmp/poi-bin-3.5-beta5-20090219.tar.gz
but shows your problem with
   emacs -Q -f url-handler-mode; C-x C-f http://.../poi... RET


-- Stefan

bug#3410: tar mode fails to open many valid files

[Paul Pogonyshev]

Not sure if it is possible to reopen a bug, but I have simliar
problems with another tarball:

    http://sunet.dl.sourceforge.net/sourceforge/hibernate/hibernate-distribution-3.3.2.GA-dist.tar.gz

    File hibernate-distribution-3.3.2.GA-dist.tar.gz is large (39MB), really open? (y or n) 
    uncompressing hibernate-distribution-3.3.2.GA-dist.tar.gz...done
    Parsing tar file...
    File mode specification error: (error "package org.hibernate.test.collection.idbag;

Note that the original tarball now opens fine, so I do have the bugfix
compiled in.  Again, this is on a 32-bit system.

Paul

bug#3410: tar mode fails to open many valid files

[Glenn Morris]

Paul Pogonyshev wrote:

> The only difference can I see is CPU architecture: you have amd64, but
> I have a 32-bit system.

Dead on. I normally use an x86_64 emacs and could see no problem; I
rebuilt on i386 and now I see it too.

bug#3410: marked as done (tar mode fails to open many valid files)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 895 bytes --]


Your message dated Thu, 04 Jun 2009 16:48:56 -0400
with message-id <jwvprdjlodm.fsf-monnier+emacsbugreports@gnu.org>
and subject line Re: bug#3410: tar mode fails to open many valid files
has caused the Emacs bug report #3410,
regarding tar mode fails to open many valid files
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com
immediately.)


-- 
3410: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=3410
Emacs Bug Tracking System
Contact owner@emacsbugs.donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 2321 bytes --]

From: Paul Pogonyshev <p.pogonyshev@anakreon.net>
To: submit@emacsbugs.donarmstrong.com
Subject: tar mode fails to open many valid files
Date: Thu, 28 May 2009 17:05:14 +0300
Message-ID: <200905281705.14463.p.pogonyshev@anakreon.net>

When I open a 'tar.gz' file in Emacs, it quite often fails with a
message similar to:

    File mode specification error: (error
    "ntWorkbookBuilder.SheetRecordCollectingListener.html\"
    title=\"class in org.apache.poi.hssf.eventuserm has size
    -137265917 - corrupted")

E.g. file at

    http://apache.promotionalpro.com/poi/dev/bin/poi-bin-3.5-beta5-20090219.tar.gz

exhibits this error.  It can be extracted without problems with 'tar
-xzf ...' at command line, so it must be a bug in Emacs' tar mode.
Maybe it is too strict or doesn't handle some extension properly.

Paul


[-- Attachment #3: Type: message/rfc822, Size: 3238 bytes --]

From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Paul Pogonyshev <p.pogonyshev@anakreon.net>
Cc: 3410-close@emacsbugs.donarmstrong.com
Subject: Re: bug#3410: tar mode fails to open many valid files
Date: Thu, 04 Jun 2009 16:48:56 -0400
Message-ID: <jwvprdjlodm.fsf-monnier+emacsbugreports@gnu.org>

> I.e. it works fine with
>    emacs -Q ~/tmp/poi-bin-3.5-beta5-20090219.tar.gz
> but shows your problem with
>    emacs -Q -f url-handler-mode; C-x C-f http://.../poi... RET

In the end you were right, and I have no idea how I managed to get the
above results.  url-handler-mode makes no difference, and the 64bit
thingy makes a difference (it somehow hides the bug, so it doesn't
signal an error but instead misinterprets the middle of the tar file,
while the beginning and the end are still just fine, so my cursory check
didn't see the corruption).

I've just installed the patch below, which should fix the problem,


        Stefan


--- tar-mode.el.~1.139.~	2009-03-20 16:24:31.000000000 -0400
+++ tar-mode.el	2009-06-04 16:41:49.000000000 -0400
@@ -276,7 +276,10 @@
             (setq link-p 5))            ; directory
 
         (if (and (equal name "././@LongLink")
-                 (equal magic-str "ustar ")) ;OLDGNU_MAGIC.
+                 ;; Supposedly @LongLink is only used for GNUTAR
+                 ;; format (i.e. "ustar ") but some POSIX Tar files
+                 ;; (with "ustar\0") have been seen using it as well.
+                 (member magic-str '("ustar " "ustar\0")))
             ;; This is a GNU Tar long-file-name header.
             (let* ((size (tar-parse-octal-integer
                           string tar-size-offset tar-time-offset))