From: Stefan Monnier <monnier@iro.umontreal.ca>
To: ARISAWA Akihiro <ari@mbf.ocn.ne.jp>
Cc: 7496@debbugs.gnu.org
Subject: bug#7496: 23.2; copy recursive keymap cause crash
Date: Fri, 26 Nov 2010 22:01:28 -0500 [thread overview]
Message-ID: <jwvhbf3fpgj.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <871v67o9ns.fsf@nagi.lyrical.homelinux.net> (ARISAWA Akihiro's message of "Sat, 27 Nov 2010 10:08:39 +0900")
> When I call `copy-keymap' with a keymap which contains recursive binding,
> the emacs crashed.
> I can reproduce it by following sexp.
> (let ((map (make-sparse-keymap)))
> (define-key map " " map)
> (copy-keymap map))
I'm not surprised. There are many ways to address it:
- try and make sure we better handle the "using up all memory" case
rather than crashing. This is very difficult. We already try to do
it, but clearly it's not working that well.
- try and detect such cycles and either signal an error or reproduce the
same cycle in the copy. We have added such things in several other
cases, so we should probably do that.
- don't use cyclic keymaps and especially don't copy them.
- don't use copy-keymap, instead: inherit.
Stefan
next prev parent reply other threads:[~2010-11-27 3:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-27 1:08 bug#7496: 23.2; copy recursive keymap cause crash ARISAWA Akihiro
2010-11-27 3:01 ` Stefan Monnier [this message]
2010-11-27 5:10 ` ARISAWA Akihiro
2019-10-13 1:15 ` Lars Ingebrigtsen
2019-10-13 6:58 ` Eli Zaretskii
2019-10-13 17:56 ` Lars Ingebrigtsen
2019-10-13 18:47 ` Eli Zaretskii
2019-10-13 20:24 ` Stefan Monnier
2019-10-13 20:34 ` Lars Ingebrigtsen
2019-10-13 21:26 ` Stefan Monnier
2019-10-13 21:38 ` Drew Adams
2019-10-14 6:09 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvhbf3fpgj.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=7496@debbugs.gnu.org \
--cc=ari@mbf.ocn.ne.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).