From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#10063: 24.0.91; Making font-lock-mode-hook buffer-local while locally let-bound! Date: Wed, 16 Nov 2011 09:49:37 -0500 Message-ID: References: <87y5vg5jzb.fsf@gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1321455034 30784 80.91.229.12 (16 Nov 2011 14:50:34 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 16 Nov 2011 14:50:34 +0000 (UTC) Cc: Lars Magne Ingebrigtsen , 10063@debbugs.gnu.org To: Leo Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Nov 16 15:50:26 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RQgoj-0007If-45 for geb-bug-gnu-emacs@m.gmane.org; Wed, 16 Nov 2011 15:50:25 +0100 Original-Received: from localhost ([::1]:34461 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RQgoi-0004DG-NI for geb-bug-gnu-emacs@m.gmane.org; Wed, 16 Nov 2011 09:50:24 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:34931) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RQgoc-0004D2-Sn for bug-gnu-emacs@gnu.org; Wed, 16 Nov 2011 09:50:23 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RQgoa-0003o8-Iw for bug-gnu-emacs@gnu.org; Wed, 16 Nov 2011 09:50:18 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:50886) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RQgoa-0003o4-HS for bug-gnu-emacs@gnu.org; Wed, 16 Nov 2011 09:50:16 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1RQgpJ-0003kL-KT for bug-gnu-emacs@gnu.org; Wed, 16 Nov 2011 09:51:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 16 Nov 2011 14:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 10063 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 10063-submit@debbugs.gnu.org id=B10063.132145503214363 (code B ref 10063); Wed, 16 Nov 2011 14:51:01 +0000 Original-Received: (at 10063) by debbugs.gnu.org; 16 Nov 2011 14:50:32 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RQgop-0003jc-TB for submit@debbugs.gnu.org; Wed, 16 Nov 2011 09:50:32 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181] helo=ironport2-out.pppoe.ca) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RQgon-0003jI-HK for 10063@debbugs.gnu.org; Wed, 16 Nov 2011 09:50:30 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AkwGAFLMw05MCqs//2dsb2JhbABDp1aCIIEGgXIBAQQBViMFCws0EhQYDSSIFbkdihcEiBSZcIRK X-IronPort-AV: E=Sophos;i="4.69,521,1315195200"; d="scan'208";a="148209066" Original-Received: from 76-10-171-63.dsl.teksavvy.com (HELO pastel.home) ([76.10.171.63]) by ironport2-out.pppoe.ca with ESMTP/TLS/ADH-AES256-SHA; 16 Nov 2011 09:49:38 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id E07115936A; Wed, 16 Nov 2011 09:49:37 -0500 (EST) In-Reply-To: <87y5vg5jzb.fsf@gmail.com> (Leo's message of "Wed, 16 Nov 2011 20:29:12 +0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.91 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Wed, 16 Nov 2011 09:51:01 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:53986 Archived-At: > I am seeing this warning in Gnus. > ,---- > | Making font-lock-mode-hook buffer-local while locally let-bound! > `---- > which seems to relate to line 602 in mm-view.el > 601: ;; Disable support modes, e.g., jit-lock, lazy-lock, etc. > 602: (font-lock-mode-hook nil) > 603: (font-lock-support-mode nil) BTW, these should not be let-bindings but buffer-local bindings. Also the mode-setting and font-locking should be wrapped in with-demoted-errors so that errors in them don't prevent showing the attachment's content. Finally, font-lock-maximum-size should not be set to nil: there is nothing special about font-locking attachments that makes it more desirable to font-lock them entirely than normal files. Stefan