From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#11381: 23.3; isearch-search-and-update issue? Date: Mon, 28 May 2012 10:08:15 -0400 Message-ID: References: <4F9DC154.2000605@groveronline.com> <87ipgggtmw.fsf@mail.jurta.org> <878vhcc4nl.fsf@mail.jurta.org> <87vcjxdt5p.fsf@mail.jurta.org> <87vcjvwtxa.fsf@mail.jurta.org> <87r4ufhfmi.fsf@mail.jurta.org> <87mx4u0xiu.fsf@mail.jurta.org> <87y5oc3cab.fsf@mail.jurta.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1338214139 18087 80.91.229.3 (28 May 2012 14:08:59 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 28 May 2012 14:08:59 +0000 (UTC) Cc: 11381@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon May 28 16:08:57 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SZ0cw-0002Ef-GF for geb-bug-gnu-emacs@m.gmane.org; Mon, 28 May 2012 16:08:54 +0200 Original-Received: from localhost ([::1]:44656 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SZ0cw-0008Lw-5g for geb-bug-gnu-emacs@m.gmane.org; Mon, 28 May 2012 10:08:54 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:35692) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SZ0cs-0008Lq-EG for bug-gnu-emacs@gnu.org; Mon, 28 May 2012 10:08:51 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SZ0cq-0004FY-K0 for bug-gnu-emacs@gnu.org; Mon, 28 May 2012 10:08:49 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:37140) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SZ0cq-0004FL-HN for bug-gnu-emacs@gnu.org; Mon, 28 May 2012 10:08:48 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1SZ0e4-00072B-GY for bug-gnu-emacs@gnu.org; Mon, 28 May 2012 10:10:04 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 28 May 2012 14:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11381 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 11381-submit@debbugs.gnu.org id=B11381.133821420027025 (code B ref 11381); Mon, 28 May 2012 14:10:01 +0000 Original-Received: (at 11381) by debbugs.gnu.org; 28 May 2012 14:10:00 +0000 Original-Received: from localhost ([127.0.0.1]:46686 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SZ0e0-00071q-3x for submit@debbugs.gnu.org; Mon, 28 May 2012 10:10:00 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:28030) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SZ0dg-00071N-B8 for 11381@debbugs.gnu.org; Mon, 28 May 2012 10:09:59 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Ai0FAG6Zu09MCpYd/2dsb2JhbABEsEiDSYEIghUBAQQBViMFCws0EhQYDSSIHAW6CZBEA6MzgViDBQ X-IronPort-AV: E=Sophos;i="4.75,637,1330923600"; d="scan'208";a="183124215" Original-Received: from 76-10-150-29.dsl.teksavvy.com (HELO pastel.home) ([76.10.150.29]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 28 May 2012 10:08:16 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 26105594DE; Mon, 28 May 2012 10:08:16 -0400 (EDT) In-Reply-To: <87y5oc3cab.fsf@mail.jurta.org> (Juri Linkov's message of "Mon, 28 May 2012 11:55:20 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:60418 Archived-At: >> Do we really need those 4? I think we can just get away with >> symbol-search-regexp (whose name also needs to start with "isearch-"). > In the next patch these functions are removed and symbol-search-regexp > is renamed to isearch-symbol-regexp. Thanks, see comments below. >>> Also it splits the standard default part of `isearch-search-fun' >> You could actually set isearch-search-fun-function's default to >> isearch-search-fun-default so we can just unconditionally call >> isearch-search-fun-function's. > It still needs protection against such cases as currently existing in > several places in internal and probably also in external packages: > (let ((isearch-search-fun-function nil)) > (isearch-search-fun)) For the internal cases, the above should be replaced by a call to isearch-search-fun-default. Obviously, if there are external such cases, we'll indeed need to additionally keep: > (funcall (or isearch-search-fun-function 'isearch-search-fun-default)) [...] > === modified file 'lisp/isearch.el' > --- lisp/isearch.el 2012-05-17 00:03:49 +0000 > +++ lisp/isearch.el 2012-05-28 08:38:31 +0000 > @@ -503,6 +512,7 @@ (defvar isearch-mode-map > (define-key map "\M-sr" 'isearch-toggle-regexp) > (define-key map "\M-sw" 'isearch-toggle-word) > + (define-key map "\M-s_" 'isearch-toggle-symbol) BTW, could you add isearch-toggle-case-fold to the M-s prefix, while you're at it? > (defun Info-isearch-search () I think we can share even more code here with isearch.el. But in any case, the patch looks good now, thank you, Stefan