From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Stephen Berman <stephen.berman@gmx.net>
Cc: 13648@debbugs.gnu.org
Subject: bug#13648: 24.3.50; remove-overlays bugs
Date: Thu, 07 Feb 2013 11:42:46 -0500 [thread overview]
Message-ID: <jwvhalocckh.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <8738x8b1pa.fsf@rosalinde.fritz.box> (Stephen Berman's message of "Thu, 07 Feb 2013 16:09:21 +0100")
> The reason for the first problem is that remove-overlays tests the
> overlay value with eq, which fails for all strings [...]
No, it won't fail on all strings. You just need to pass it the same
string you added to the overlay, rather than a copy of it.
I.e. this is not a bug.
> invocation of remove-overlays is legitimate), the logic of the code is
> that the NAME and VAL arguments are either both nil or both non-nil,
Indeed.
> which conflicts with the semantics of the &optional keyword.
Right. We should document it in the docstring.
> This means that the last call of remove-overlays in the above sexp
> would clear any after-string overlays, regardless of their value.
Normally we don't distinguish "an property FOO of value nil" and "no
property FOO". So I think what would make sense is to say that if VAL
is nil, then we remove any overlay whose NAME property is non-nil
(i.e. the exact inverse from what we currently do).
This said, the reason why I have not implemented this case of NAME being
specified while VAL is left unspecified is because I haven't come up
with a need for it. So I'd be interested to hear the backstory of
why/where you need it.
Stefan
next prev parent reply other threads:[~2013-02-07 16:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-07 15:09 bug#13648: 24.3.50; remove-overlays bugs Stephen Berman
2013-02-07 16:42 ` Stefan Monnier [this message]
2013-02-07 19:16 ` Stephen Berman
2013-02-08 1:45 ` Stefan Monnier
2013-02-08 14:50 ` Stephen Berman
2020-08-25 11:44 ` Lars Ingebrigtsen
2020-08-25 13:02 ` Eli Zaretskii
2020-08-25 13:55 ` Stefan Monnier
2020-08-25 14:23 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvhalocckh.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=13648@debbugs.gnu.org \
--cc=stephen.berman@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).