From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#14710: add-file-local-variable vs. unquoted string Date: Tue, 25 Jun 2013 09:06:52 -0400 Message-ID: References: <877ghjl0xm.fsf@jidanni.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1372165715 1259 80.91.229.3 (25 Jun 2013 13:08:35 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 25 Jun 2013 13:08:35 +0000 (UTC) Cc: 14710-done@debbugs.gnu.org To: jidanni@jidanni.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jun 25 15:08:34 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UrSyj-0003O6-Ig for geb-bug-gnu-emacs@m.gmane.org; Tue, 25 Jun 2013 15:08:13 +0200 Original-Received: from localhost ([::1]:45946 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UrSyj-0005Lm-4E for geb-bug-gnu-emacs@m.gmane.org; Tue, 25 Jun 2013 09:08:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42482) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UrSyf-0005Lf-2P for bug-gnu-emacs@gnu.org; Tue, 25 Jun 2013 09:08:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UrSya-0003EU-8p for bug-gnu-emacs@gnu.org; Tue, 25 Jun 2013 09:08:09 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:45715) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UrSya-0003EQ-5y for bug-gnu-emacs@gnu.org; Tue, 25 Jun 2013 09:08:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1UrSyZ-000210-Gg for bug-gnu-emacs@gnu.org; Tue, 25 Jun 2013 09:08:03 -0400 Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Tue, 25 Jun 2013 13:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 14710 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Mail-Followup-To: 14710@debbugs.gnu.org, monnier@iro.umontreal.ca, jidanni@jidanni.org Original-Received: via spool by 14710-done@debbugs.gnu.org id=D14710.13721656217613 (code D ref 14710); Tue, 25 Jun 2013 13:08:02 +0000 Original-Received: (at 14710-done) by debbugs.gnu.org; 25 Jun 2013 13:07:01 +0000 Original-Received: from localhost ([127.0.0.1]:40018 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UrSxZ-0001yd-E8 for submit@debbugs.gnu.org; Tue, 25 Jun 2013 09:07:01 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:27061) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UrSxW-0001yI-PD for 14710-done@debbugs.gnu.org; Tue, 25 Jun 2013 09:06:59 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av8EABK/CFFMCppA/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCws0EhQYDYhCBrEfkA6NYYMpA6R6gV6DEw X-IPAS-Result: Av8EABK/CFFMCppA/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCws0EhQYDYhCBrEfkA6NYYMpA6R6gV6DEw X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="17111330" Original-Received: from 76-10-154-64.dsl.teksavvy.com (HELO fmsmemgm.homelinux.net) ([76.10.154.64]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 25 Jun 2013 09:06:47 -0400 Original-Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 597F6AE246; Tue, 25 Jun 2013 09:06:52 -0400 (EDT) In-Reply-To: <877ghjl0xm.fsf@jidanni.org> (jidanni@jidanni.org's message of "Tue, 25 Jun 2013 04:16:05 +0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:75553 Archived-At: > Try > M-x add-file-local-variable > compile-command > a b c > Note how b c are thrown away. > Yes the user should have typed "a b c", > but still some warning should be printed upon throwing them away. Good point. I fixed it with the patch below, which uses read-from-minibuffer (with a non-nil `read' argument) instead of read-string, so it re-uses the check that was already used when reading an Elisp expression. Stefan === modified file 'lisp/files-x.el' --- lisp/files-x.el 2013-06-18 20:38:43 +0000 +++ lisp/files-x.el 2013-06-25 12:59:31 +0000 @@ -71,12 +69,14 @@ (format "Add %s with value: " variable)) default)) (t - (read (read-string (format "Add %s with value: " variable) - nil 'set-variable-value-history - (format "%S" + (let ((default (format "%S" (cond ((eq variable 'unibyte) t) ((boundp variable) - (symbol-value variable)))))))))) + (symbol-value variable))))) + (minibuffer-completing-symbol t)) + (read-from-minibuffer (format "Add %s with value: " variable) + nil read-expression-map t + 'set-variable-value-history))))) (defun read-file-local-variable-mode () "Read per-directory file-local variable's mode using completion.