From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#23949: 25.0.95; Regression in handling error caused by (string-match-p "." nil) Date: Wed, 13 Jul 2016 09:59:33 -0400 Message-ID: References: <83lh17ati6.fsf@gnu.org> <83h9bvarb6.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1468419269 32725 80.91.229.3 (13 Jul 2016 14:14:29 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 13 Jul 2016 14:14:29 +0000 (UTC) Cc: schwab@suse.de, 23949@debbugs.gnu.org To: Kaushal Modi Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jul 13 16:14:18 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bNKvV-0008My-0s for geb-bug-gnu-emacs@m.gmane.org; Wed, 13 Jul 2016 16:14:13 +0200 Original-Received: from localhost ([::1]:47864 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bNKvU-0008Ce-9Y for geb-bug-gnu-emacs@m.gmane.org; Wed, 13 Jul 2016 10:14:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34805) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bNKhs-0001ey-L6 for bug-gnu-emacs@gnu.org; Wed, 13 Jul 2016 10:00:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bNKhn-0003Kg-5a for bug-gnu-emacs@gnu.org; Wed, 13 Jul 2016 10:00:08 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:37563) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bNKhn-0003KW-1t for bug-gnu-emacs@gnu.org; Wed, 13 Jul 2016 10:00:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bNKhm-0002MK-MJ for bug-gnu-emacs@gnu.org; Wed, 13 Jul 2016 10:00:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 13 Jul 2016 14:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23949 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23949-submit@debbugs.gnu.org id=B23949.14684183899016 (code B ref 23949); Wed, 13 Jul 2016 14:00:02 +0000 Original-Received: (at 23949) by debbugs.gnu.org; 13 Jul 2016 13:59:49 +0000 Original-Received: from localhost ([127.0.0.1]:49900 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bNKhU-0002LI-Q5 for submit@debbugs.gnu.org; Wed, 13 Jul 2016 09:59:49 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:3495) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bNKhP-0002L1-8p for 23949@debbugs.gnu.org; Wed, 13 Jul 2016 09:59:43 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0A2FgA731xV/3mcpUVcgxCEAoVVwwsEAgKBPDwRAQEBAQEBAYEKQQWDXQEBAwFWIwULCzQSFBgNJC6ICQjPIwEBAQcCAR+LOoE9AYNHB4QtBbM/gUUjgWYkDQ+BbiKCeAEBAQ X-IPAS-Result: A0A2FgA731xV/3mcpUVcgxCEAoVVwwsEAgKBPDwRAQEBAQEBAYEKQQWDXQEBAwFWIwULCzQSFBgNJC6ICQjPIwEBAQcCAR+LOoE9AYNHB4QtBbM/gUUjgWYkDQ+BbiKCeAEBAQ X-IronPort-AV: E=Sophos;i="5.13,465,1427774400"; d="scan'208";a="247759837" Original-Received: from 69-165-156-121.dsl.teksavvy.com (HELO pastel.home) ([69.165.156.121]) by ironport2-out.teksavvy.com with ESMTP; 13 Jul 2016 09:59:45 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 5A0BB64CB1; Wed, 13 Jul 2016 09:59:33 -0400 (EDT) In-Reply-To: (Kaushal Modi's message of "Wed, 13 Jul 2016 13:10:46 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:120988 Archived-At: >> That's a general problem with the use dynamic binding to pass extra >> parameters: you end up passing them not just to that one function but >> also to all other functions called from that one. > So what is the way forward? I think it's a fairly fundamental problem that's hard/impossible to "fix". > Fixing just string-match-p and string-match does not seem to the complete > solution, because I have seen just let-bound dynamic vars at many places. A way to fix *some* of the problems is to use concurrency (not yet in "master"), and make the debugger run in another thread so it's not affected by the dynamic bindings of the code that signaled the error. For the more general problem, the only "fix" is to try and remove those uses of dynamic bindings and replace them with something else, which seems like a very large undertaking and whose benefits are not necessarily that clear (the problem being to decide what that "something else" should be, and the fact that this "something else" will come with its own problems). In the case of string-match-p I think we should get rid of inhibit-changing-match-data and implement string-match-p (and looking-at-p) some other way. Stefan