From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#36564: 27.0.50; Wrong number of errors in compilation mode-line Date: Thu, 11 Jul 2019 18:32:10 -0400 Message-ID: References: <871ryzhskw.fsf@mail.linkov.net> <87ef2xmsct.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="231564"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 36564@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jul 12 00:33:08 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hlhch-000y6H-L9 for geb-bug-gnu-emacs@m.gmane.org; Fri, 12 Jul 2019 00:33:07 +0200 Original-Received: from localhost ([::1]:45604 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hlhcg-0000PI-Hp for geb-bug-gnu-emacs@m.gmane.org; Thu, 11 Jul 2019 18:33:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40272) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hlhcd-0000Oz-SX for bug-gnu-emacs@gnu.org; Thu, 11 Jul 2019 18:33:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hlhcc-0003SB-Pk for bug-gnu-emacs@gnu.org; Thu, 11 Jul 2019 18:33:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58409) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hlhcc-0003Rw-Hc for bug-gnu-emacs@gnu.org; Thu, 11 Jul 2019 18:33:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hlhcc-0006DH-EC for bug-gnu-emacs@gnu.org; Thu, 11 Jul 2019 18:33:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 11 Jul 2019 22:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36564 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed patch Original-Received: via spool by 36564-submit@debbugs.gnu.org id=B36564.156288434523821 (code B ref 36564); Thu, 11 Jul 2019 22:33:02 +0000 Original-Received: (at 36564) by debbugs.gnu.org; 11 Jul 2019 22:32:25 +0000 Original-Received: from localhost ([127.0.0.1]:38991 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hlhby-0006C6-SU for submit@debbugs.gnu.org; Thu, 11 Jul 2019 18:32:25 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:15348) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hlhbv-0006Bn-J4 for 36564@debbugs.gnu.org; Thu, 11 Jul 2019 18:32:20 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 1C0A0444A90; Thu, 11 Jul 2019 18:32:13 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id C3464444A7A; Thu, 11 Jul 2019 18:32:11 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1562884331; bh=P1/SEESbCVGmiBNNFSu4ls81S5ZyKWZEqr4b2j4L24s=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=MNXxuX+fFg0tFOdi9qhlInqaGxJs4tIiTSwSxgJymcLifcoLMm0aDADZ4WuuiCtk9 PNkB2Pu/OLxOoYBkI7pg0Lx6bQ6S4nuExRR4xPmEfEGYBdrFBSZvP2J4WE0eti6l0d lIDRwVmp1r2HFAOkPxabOW+58LcClCvMK02Og8A2CzO+I2KdD+gKqcgTFQO2m5NMms 0IG1IEEKqQOBn71KAEzGhr5DbRJ08/gIygWnFryLQP6D3EYY4lJPjglkufW3nAA//0 OoY07jdVK+ouXQykxNzwI0fgYjqG/ijR4P17T7d92WEnmGax/3WQgBfQ1Gawg8bjTo gRyVvP34ZDWTA== Original-Received: from milanesa (104-222-123-229.cpe.teksavvy.com [104.222.123.229]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 867DD12023B; Thu, 11 Jul 2019 18:32:11 -0400 (EDT) In-Reply-To: <87ef2xmsct.fsf@mail.linkov.net> (Juri Linkov's message of "Thu, 11 Jul 2019 01:34:27 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:162739 Archived-At: > --- a/lisp/progmodes/compile.el > +++ b/lisp/progmodes/compile.el > @@ -2245,6 +2250,8 @@ compilation-filter > (unless comint-inhibit-carriage-motion > (comint-carriage-motion (process-mark proc) (point))) > (set-marker (process-mark proc) (point)) > + ;; Update the number of errors in compilation-mode-line-errors > + (font-lock-ensure compilation-filter-start (point)) I worry that doing it there will slow down processing too much. But even if we want to do it there, I think font-lock-ensure is wrong because we shouldn't *highlight* (e.g. the user may prefer font-lock to be disabled). Does compilation--ensure-parse do what you want? Stefan