unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 41989@debbugs.gnu.org, Philipp Stephani <p.stephani2@gmail.com>
Subject: bug#41989: 28.0.50; Edebug doesn't generate symbols for `cl-flet' etc.
Date: Tue, 02 Mar 2021 08:58:08 -0500	[thread overview]
Message-ID: <jwvh7ltmzn2.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87im6ayrd8.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 02 Mar 2021 07:57:55 +0100")

>>> I'm not quite sure what the status is here now.  I tried `C-u C-M-x'-ing
>>> it now and got:
>>>
>>> Edebug: foo@cl-flet@118
>>> Edebug: foo@cl-flet@119
>>> Edebug: bar
>>> bar
>>>
>>> Which seems correct.  And stepping through the function also works.  So
>>> is there more to be done here?
>>
>> It would be nice to include the outer function ("bar") in the
>> generated symbol, e.g. "bar@foo@cl-flet@118" or similar.
>> But that would really be the icing on the cake, and it's not necessary
>> to avoid duplicate symbols. So more of a nice to have; feel free to
>> close this bug if it's too hard to implement.
>
> Ah, right.  Yes, that does sound like an even better way to name these
> flets -- easier to identify in backtraces and the like (but I guess
> normally the backtrace would also tell you the enclosing function, so
> perhaps the utility would be limited)...
>
> Perhaps Stefan M has an opinion here?  Added to the CCs.

[ I recently worked on this part of Edebug, which incidentally lead me
  to fix bug#41988.  ]

I think it wouldn't be very hard to add the outer function(s) name(s),
but it wouldn't remove the need for the "@NNN" to make the functions
unique.  Also I'm still not quite sure why those names matter, to be
honest, so the motivation to improve the behavior is fairly low.


        Stefan






  reply	other threads:[~2021-03-02 13:58 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-21 17:03 bug#41989: 28.0.50; Edebug doesn't generate symbols for `cl-flet' etc Philipp
2020-08-02 15:42 ` Philipp Stephani
2021-03-01 15:46   ` Lars Ingebrigtsen
2021-03-01 15:59     ` Philipp Stephani
2021-03-02  6:57       ` Lars Ingebrigtsen
2021-03-02 13:58         ` Stefan Monnier [this message]
2021-03-03 14:49           ` Lars Ingebrigtsen
2021-03-03 16:45             ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvh7ltmzn2.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=41989@debbugs.gnu.org \
    --cc=larsi@gnus.org \
    --cc=p.stephani2@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).