From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#56682: Fix the long lines font locking related slowdowns Date: Tue, 02 Aug 2022 17:32:14 -0400 Message-ID: References: <8a3eaeef01be5bfaa5ef@heytings.org> <05388e8d8812bfa3695d@heytings.org> <83v8rf5894.fsf@gnu.org> <65cb7c73fd4a999cca00@heytings.org> <8c7321f2f3400a5db9be@heytings.org> <8c7321f2f388e5343475@heytings.org> <6ea376f6-d503-06d8-6d83-50c52b695394@yandex.ru> <8c7321f2f3ac52bfee4b@heytings.org> <8c7321f2f3ec1ef81af9@heytings.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17284"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 56682@debbugs.gnu.org, Eli Zaretskii , Dmitry Gutov To: Gregory Heytings Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Aug 02 23:33:32 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oIzW8-0004Gw-7o for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 02 Aug 2022 23:33:32 +0200 Original-Received: from localhost ([::1]:53236 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oIzW6-00060x-O5 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 02 Aug 2022 17:33:30 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42718) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oIzVe-00060l-72 for bug-gnu-emacs@gnu.org; Tue, 02 Aug 2022 17:33:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55486) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oIzVd-0004af-T8 for bug-gnu-emacs@gnu.org; Tue, 02 Aug 2022 17:33:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oIzVd-0002mN-Mx for bug-gnu-emacs@gnu.org; Tue, 02 Aug 2022 17:33:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 02 Aug 2022 21:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56682 X-GNU-PR-Package: emacs Original-Received: via spool by 56682-submit@debbugs.gnu.org id=B56682.165947594910639 (code B ref 56682); Tue, 02 Aug 2022 21:33:01 +0000 Original-Received: (at 56682) by debbugs.gnu.org; 2 Aug 2022 21:32:29 +0000 Original-Received: from localhost ([127.0.0.1]:45235 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oIzV7-0002lX-E6 for submit@debbugs.gnu.org; Tue, 02 Aug 2022 17:32:29 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:15340) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oIzV5-0002lJ-JH for 56682@debbugs.gnu.org; Tue, 02 Aug 2022 17:32:28 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id AA3DE4421EF; Tue, 2 Aug 2022 17:32:21 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 2F3354421F8; Tue, 2 Aug 2022 17:32:20 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1659475940; bh=ibP4Wd1vzrRS5l/TRumsZhPEJFaADZeOe9r7Lz6Vw/0=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=Ldhujt3Co6ER7JCEWkCEPjRl0J/qiimKa4IaVF39ZiT6pn0ztm01WJcPDFCKbBnSl IkRV/7lLkx8/O9Tj7OxN837QxxaFgf3GXbFN2Yq+9xKQMJXItaN2FmY3RgE7EkGEjl grPbvFvl6Vsomsb8OJ3jXV+OOJqRjFp22Ws0T5zO/b82uLN0QjF3Hod8XietZh6dGg ttNLlJYeuROx8zYNc9lbgnZXwDlZlGAxMvI5ej+dSfnZG2X2pByaLcqe/g+9rfhykr 9cqWqATrVI+TQ35OFi5tVgAPy6YcLmEhZ2IuA0ovqe6C4l69VoXdNZI8UGYJuqY4Cz qp6ymz6XveZ1Q== Original-Received: from milanesa (unknown [46.44.221.102]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 2CAF1120476; Tue, 2 Aug 2022 17:32:19 -0400 (EDT) In-Reply-To: (Gregory Heytings's message of "Mon, 01 Aug 2022 11:23:52 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:238587 Archived-At: Gregory Heytings [2022-08-01 11:23:52] wrote: >>> The problem is that this is, as I said, slow. On my laptop, opening >>> a 1 GB file takes about 6 seconds. The call to syntax-ppss adds 70 >>> seconds, so opening a large file becomes an order of magnitude slower (13 >>> times slower). >> >> It's meaningless to talk about the time taken by `syntax-ppss` without >> specifying the major mode that was in use. >> > > It isn't. The benchmark above was with a JSON file (js-mode), but you'll > see the same ratio with an Elisp file for example: Hmmm was that using the GNU ELPA `json-mode` package? If so, then indeed there's no `syntax-propertize-function` setup there and `syntax-ppss` should be ideally not much slower than `parse-partial-sexp`. > for I in $(seq 1 2500); do cat lisp/simple.el; done > complex.el > > That file opens in about 5 seconds, and (benchmark-run 1 (syntax-ppss > (point-max))) takes about 45 seconds. > > Sure, there are perhaps modes that are slower, but my tests seem to indicate > that the 1/10 ratio is correct, or IOW that syntax-ppss is an order of > magnitude slower than opening the file. You might be right. But there are still significant differences between different major modes: LISP> (benchmark-run 1 (fundamental-mode) (parse-partial-sexp (point-min) (point-max))) (0.276774213 0 0.0) LISP> (benchmark-run 1 (fundamental-mode) (syntax-ppss (point-max))) (0.329234636 0 0.0) ELISP> (benchmark-run 1 (emacs-lisp-mode) (syntax-ppss (point-max))) (0.392759479 0 0.0) ELISP> (benchmark-run 1 (js-mode) (syntax-ppss (point-max))) (1.036089104 7 0.20054423700000001) ELISP> (benchmark-run 1 (nxml-mode) (syntax-ppss (point-max))) (1.169055192 7 0.15886504199999996) ELISP> (benchmark-run 1 (cperl-mode) (syntax-ppss (point-max))) (1.857638439 9 0.19724271499999996) (this was in a 5MB buffer). Stefan