From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#64101: 29.0.91; Eglot inlay hints rendered out of order Date: Sun, 18 Jun 2023 11:20:05 -0400 Message-ID: References: <83r0qar07l.fsf@gnu.org> <877cs28m23.fsf@gmail.com> <87v8fl7mko.fsf@gmail.com> <87mt0w7sv2.fsf@gmail.com> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15875"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , Krzysztof Klimonda , 64101@debbugs.gnu.org To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jun 18 17:21:18 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qAuDO-0003t8-CE for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 18 Jun 2023 17:21:18 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qAuDA-0007kG-8z; Sun, 18 Jun 2023 11:21:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qAuD8-0007ji-Nv for bug-gnu-emacs@gnu.org; Sun, 18 Jun 2023 11:21:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qAuD8-0006xN-Fi for bug-gnu-emacs@gnu.org; Sun, 18 Jun 2023 11:21:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qAuD8-0004Px-C3 for bug-gnu-emacs@gnu.org; Sun, 18 Jun 2023 11:21:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 18 Jun 2023 15:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64101 X-GNU-PR-Package: emacs Original-Received: via spool by 64101-submit@debbugs.gnu.org id=B64101.168710161916863 (code B ref 64101); Sun, 18 Jun 2023 15:21:02 +0000 Original-Received: (at 64101) by debbugs.gnu.org; 18 Jun 2023 15:20:19 +0000 Original-Received: from localhost ([127.0.0.1]:54836 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qAuCR-0004Nv-0p for submit@debbugs.gnu.org; Sun, 18 Jun 2023 11:20:19 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:36691) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qAuCP-0004Ng-B4 for 64101@debbugs.gnu.org; Sun, 18 Jun 2023 11:20:17 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id A5E9D44087E; Sun, 18 Jun 2023 11:20:11 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id DFEEB44094F; Sun, 18 Jun 2023 11:20:05 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1687101605; bh=7zEAW0N5M7MI+XkF3wiztdz44rvJrTbUvYCtgDAEpQA=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=g8/Dx7pEJJR+UlAE88Ueyw8qCS3uhjD6XU4RAiSV/71/2QwqQYMVOctLVOm3mIeOt 6K1ibdSExZma71pcK5uYq7Gn+CCMbMfwMbu+E//MhiqkHlpafDYHjFozoYImQ3Ovo/ kMx93vgNuM+qlacgp+rufa/5+K+TWGMpM+erzrCwHEEkWOCafT6WhkzfMeB1dinM/S LpnsZJCRS28T1WqlV0r7LS9fsE8h9lTag3eHLsq5qpsyWbJk9bcTopvvWDY4NySE5h 3PpRgNW2sk7cLCoLSxeQWzIB6JLLplnvQ1e4Kbj/9Dup5lfRAlIQkTmx0qrpfsW7tL hnt6TuEMQzCRg== Original-Received: from pastel (unknown [45.72.207.87]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id AA8FF1204A2; Sun, 18 Jun 2023 11:20:05 -0400 (EDT) In-Reply-To: (Stefan Monnier's message of "Sun, 18 Jun 2023 10:36:13 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:263640 Archived-At: >> Anyway, can you explain this? > [ Revised answer: ] Yes. The patch below won't fix it, but maybe it can help someone else write an actual fix? AFAICT the place that needs fixing is the one in xdisp.c Stefan diff --git a/src/buffer.c b/src/buffer.c index 0c46b201586..26938dc5f78 100644 --- a/src/buffer.c +++ b/src/buffer.c @@ -3376,6 +3376,10 @@ record_overlay_string (struct sortstrlist *ssl, Lisp_Object str, that string via PSTR, if that variable is non-NULL. The storage of the concatenated strings may be overwritten by subsequent calls. */ +/* AFAICT, this is used only by indent.c:compute_motion, + which does not actually care about the ordering of the strings + but only its total width. */ + ptrdiff_t overlay_strings (ptrdiff_t pos, struct window *w, unsigned char **pstr) { @@ -3416,6 +3420,7 @@ overlay_strings (ptrdiff_t pos, struct window *w, unsigned char **pstr) endpos - startpos); } + /* FIXME: Use `sort_overlays` instead? */ if (overlay_tails.used > 1) qsort (overlay_tails.buf, overlay_tails.used, sizeof (struct sortstr), cmp_for_strings); diff --git a/src/xdisp.c b/src/xdisp.c index 8bcf2acfe04..f487dfbb5ba 100644 --- a/src/xdisp.c +++ b/src/xdisp.c @@ -6794,6 +6794,7 @@ #define RECORD_OVERLAY_STRING(OVERLAY, STRING, AFTER_P) \ /* Sort entries. */ if (n > 1) + /* FIXME: Use `sort_overlays` instead? */ qsort (entries, n, sizeof *entries, compare_overlay_entries); /* Record number of overlay strings, and where we computed it. */