From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#65051: internal_equal manipulates symbols with position without checking symbols-with-pos-enabled. Date: Mon, 07 Aug 2023 22:56:31 -0400 Message-ID: References: Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36062"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 65051@debbugs.gnu.org To: Alan Mackenzie Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Aug 08 04:57:20 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qTCuN-0009AZ-F9 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 08 Aug 2023 04:57:19 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qTCu8-0007lj-Vv; Mon, 07 Aug 2023 22:57:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qTCu7-0007aD-6L for bug-gnu-emacs@gnu.org; Mon, 07 Aug 2023 22:57:03 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qTCu6-0004Hc-T0 for bug-gnu-emacs@gnu.org; Mon, 07 Aug 2023 22:57:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qTCu6-0002VY-CG for bug-gnu-emacs@gnu.org; Mon, 07 Aug 2023 22:57:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 08 Aug 2023 02:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65051 X-GNU-PR-Package: emacs Original-Received: via spool by 65051-submit@debbugs.gnu.org id=B65051.16914634179629 (code B ref 65051); Tue, 08 Aug 2023 02:57:02 +0000 Original-Received: (at 65051) by debbugs.gnu.org; 8 Aug 2023 02:56:57 +0000 Original-Received: from localhost ([127.0.0.1]:34645 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qTCu1-0002VF-2O for submit@debbugs.gnu.org; Mon, 07 Aug 2023 22:56:57 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:38021) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qTCtv-0002Ux-US for 65051@debbugs.gnu.org; Mon, 07 Aug 2023 22:56:55 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 4F35C10009F; Mon, 7 Aug 2023 22:56:46 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1691463405; bh=PMRzrgqX3HRgudknz8HvzvwcjbprgukzEUTsy3MymVY=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=ENOxro1dFTOaMkc1UDT1AySAag5vj0AzW57yQZYQcs6vhVdyvayTotE9MqUCc+Ujd 3aGlhjQvu2a0oMyl57/6Jq4wiIoI56CTf7KNje7OWHJ/X7zSOvTH8FK4jJ0Te/iWEZ 5SeH1nFqoUAYYEXUMletxW5DhZDCf/+QsrmWGr70JguZNGwV+qyYCutisyWd1GoOCC g2ctNkhB0EDjVQ6Nj48c1/Arjtge79bh04OfDfy5ZKCo5EiRB2lNXRf71J/Txz1X10 guvUPDLT8DdKm6e5u3JIhnS711frotp11PDkpFjW4FxEwAGdvyyzWsxzQZmSdtT42u NIkeQ5+6/VqIg== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 43EE010007D; Mon, 7 Aug 2023 22:56:45 -0400 (EDT) Original-Received: from alfajor (host56.201-252-107.telecom.net.ar [201.252.107.56]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 566C41202B9; Mon, 7 Aug 2023 22:56:44 -0400 (EDT) In-Reply-To: (Alan Mackenzie's message of "Mon, 7 Aug 2023 09:20:25 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:266915 Archived-At: >> Could you explain why you think it's a bug? > When symbols-with-pos-enabled is non-nil, the two arguments to that > equal call are equal. That is the point of s-w-p-e. AFAIK the point of the `symbols-with-pos-enabled` is to try and keep the performance impact of sympos under control, and that matters only for `eq`, so I don't think there's a strong reason here for `equal` to pay attention to it. > When s-w-p-e is nil, and the "magic" is thus switched off, the two lisp > objects have different type (the first is a symbol, the second is a > pseudovector), thus cannot be equal. "cannot" is obviously not the correct word here, since currently they are considered `equal`, so clearly they *can* be considered `equal`: it's easy to implement, and experience shows that "it works". So I'm still wondering why you think it's a bug. AFAICT whether sympos should be `equal` to others and/or to bare symbols is something we pretty much get to choose freely based on convenience: either the current behavior or the one you now advocate are perfectly acceptable and not bugs. As I said elsewhere, I'm not sure which choice is best, but at least we have some experience with the current choice and I haven't seen any clear problem with it yet, so I'd tend to lean towards keeping the current behavior. What would be the concrete advantages of the new behavior compared to the current one? Stefan