From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#65137: 29.1; completion-substring-try-completion doesn't return the longest common substring Date: Tue, 29 Aug 2023 21:31:51 -0400 Message-ID: References: <83a5v1okwm.fsf@gnu.org> <875y5pk8rj.fsf@catern.com> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10204"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Spencer Baugh , Eli Zaretskii , 65137@debbugs.gnu.org To: sbaugh@catern.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Aug 30 03:33:13 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qbA52-0002QJ-RV for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 30 Aug 2023 03:33:13 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qbA4m-0008E4-L2; Tue, 29 Aug 2023 21:32:56 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qbA4l-0008Dw-E1 for bug-gnu-emacs@gnu.org; Tue, 29 Aug 2023 21:32:55 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qbA4l-0000aH-64 for bug-gnu-emacs@gnu.org; Tue, 29 Aug 2023 21:32:55 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qbA4s-0006Vp-6H for bug-gnu-emacs@gnu.org; Tue, 29 Aug 2023 21:33:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Aug 2023 01:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65137 X-GNU-PR-Package: emacs Original-Received: via spool by 65137-submit@debbugs.gnu.org id=B65137.169335913124974 (code B ref 65137); Wed, 30 Aug 2023 01:33:02 +0000 Original-Received: (at 65137) by debbugs.gnu.org; 30 Aug 2023 01:32:11 +0000 Original-Received: from localhost ([127.0.0.1]:51847 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qbA43-0006Uk-4l for submit@debbugs.gnu.org; Tue, 29 Aug 2023 21:32:11 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:31479) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qbA3y-0006UA-JX for 65137@debbugs.gnu.org; Tue, 29 Aug 2023 21:32:09 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id A9775100106; Tue, 29 Aug 2023 21:31:53 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1693359112; bh=oG1nFmoWJOQFRC+KQ0fFxdsEqKK9P8pfNfCwnv2lHsY=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=Bjd2W8AaUwZwcGJ3WA/X9Y8qjp6y0P3zmz9kGr16sYzqg2MVF6SJbCoYH35dEtFCz qAlQsBXL/6kWM1NCw/gmE8+O9yqelqMmtB6FIugp/WrVqS1oOo8ArXNTO5roy+j4dd 3ghbWgsamoZ1+X5m30wcO0WlSrm4inewT0uxW1uPEFPOzbHHCMjvWpTbmEwpoxLTzZ Us4rxdIf3qtPmiskZ5kS0a6UUlsgk/r2IClDzuOVh9PMxYpXh7AU4voKoadI1yL8lZ fb9IuAmeBHU3oQmdPKlgnryr/VgiPyGsLjappYKN3+CdwgLaEzvNwqbvaqd0gIlcMq qmGG5AIpGtkRQ== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 9555710006B; Tue, 29 Aug 2023 21:31:52 -0400 (EDT) Original-Received: from pastel (unknown [45.72.229.156]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 67B55120432; Tue, 29 Aug 2023 21:31:52 -0400 (EDT) In-Reply-To: <875y5pk8rj.fsf@catern.com> (sbaugh@catern.com's message of "Tue, 08 Aug 2023 12:40:01 +0000 (UTC)") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:268686 Archived-At: > (completion-pcm--merge-completions '("ab" "ab") '(prefix "b")) > -> ("b") Right this is a bug. (completion-pcm--merge-completions '("ab" "sab") '(prefix "b")) returns (correctly) ("b" "a" prefix) so (completion-pcm--merge-completions '("ab" "ab") '(prefix "b")) should return either ("b" "a") or ("b" "a" prefix). Could you accompany your patch of a regression test using `completion-pcm--merge-completions` as above? Similarly, I see that (completion-pcm--merge-completions '("abr" "absabr") '(prefix "br")) returns ("br" prefix) whereas it should arguably return ("br" "a" prefix) [ Tho this may have the side effect that after this completion, `absabr` won't be considered any more, if the `basic` completion comes before `substring` :-( ] Stefan