From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#66636: Move lexical-binding warning from checkdoc to byte-compiler Date: Thu, 19 Oct 2023 10:12:25 -0400 Message-ID: References: <48764CD1-C80F-4613-9848-BD8CA9203A40@gmail.com> <83sf66u8rt.fsf@gnu.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13773"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= , 66636@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Oct 19 16:14:02 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qtTmj-0003N6-UA for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 19 Oct 2023 16:14:02 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qtTmU-0004eG-7A; Thu, 19 Oct 2023 10:13:46 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qtTmJ-0004cp-W7 for bug-gnu-emacs@gnu.org; Thu, 19 Oct 2023 10:13:36 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qtTmJ-0006N8-Nl for bug-gnu-emacs@gnu.org; Thu, 19 Oct 2023 10:13:35 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qtTmk-0006Ag-AH for bug-gnu-emacs@gnu.org; Thu, 19 Oct 2023 10:14:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 19 Oct 2023 14:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66636 X-GNU-PR-Package: emacs Original-Received: via spool by 66636-submit@debbugs.gnu.org id=B66636.169772478323622 (code B ref 66636); Thu, 19 Oct 2023 14:14:02 +0000 Original-Received: (at 66636) by debbugs.gnu.org; 19 Oct 2023 14:13:03 +0000 Original-Received: from localhost ([127.0.0.1]:37377 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qtTlm-00068w-Sg for submit@debbugs.gnu.org; Thu, 19 Oct 2023 10:13:03 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:36250) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qtTlk-00068P-2t for 66636@debbugs.gnu.org; Thu, 19 Oct 2023 10:13:01 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 1A0B3100151; Thu, 19 Oct 2023 10:12:28 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1697724746; bh=06dabul+I0W+576+D7f9c+0f53bduDOUr0UfqJWdhlQ=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=ed8cSvOJZ69B3xAvKAYBTuWIjODSJfLA0NBjUEsuzJZYUylFQsb5dS1hPXVPyf7f4 tmb19wmZ0A4NJVQStZobNnXXqFRE+havFIa2kmbQrWIlnjossQq6V7MMPVS6OSB6z1 B6Rg5V3t/Yg7Wvq/ORWrVq/TbFdWhmmTUx9ZQDvnKjc0cZxcN3oz9PF/LAgo50LJwT Pv/KhEUIzBeAZVKyQo+Qq6UvXnhU3c96IvadGnWvlq94zuOgLBAMy7EXeKJX25DPhQ YcTQsVel6+rI/HYVRAkV+xvd89fyEL7VD8WS5vD6W7/j2uxiPCtaN+7At3VecZjz2L nJxh7D3uGrKRA== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id E57531000A3; Thu, 19 Oct 2023 10:12:26 -0400 (EDT) Original-Received: from pastel (unknown [45.72.216.111]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id BA63312031C; Thu, 19 Oct 2023 10:12:26 -0400 (EDT) In-Reply-To: <83sf66u8rt.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 19 Oct 2023 14:55:02 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:272743 Archived-At: >> The warning about a missing lexical-binding cookie rather belongs in the >> compiler than checkdoc, because it's not about documentation or style but >> code generation and ability to detect errors, both which are hindered by >> a missing cookie. >> >> Moving the warning to the compiler also makes it more widely seen. I think it's a great idea. I hadn't noticed this warning in checkdoc, else I would have probably suggested the same. The patch looks good too (and the resulting simplicity, to me, is a good hint that it's a better place to put this warning). Stefan