From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#9353: 24.0.50; default grep file name face is uglier now Date: Tue, 23 Aug 2011 20:24:14 -0400 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1314145483 6408 80.91.229.12 (24 Aug 2011 00:24:43 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 24 Aug 2011 00:24:43 +0000 (UTC) Cc: 9353@debbugs.gnu.org To: "Drew Adams" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Aug 24 02:24:39 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Qw1Gn-0006AN-Jm for geb-bug-gnu-emacs@m.gmane.org; Wed, 24 Aug 2011 02:24:37 +0200 Original-Received: from localhost ([::1]:33043 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qw1Gm-0000pO-Pz for geb-bug-gnu-emacs@m.gmane.org; Tue, 23 Aug 2011 20:24:36 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:34202) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qw1Gj-0000p2-DF for bug-gnu-emacs@gnu.org; Tue, 23 Aug 2011 20:24:34 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qw1Gi-0002su-8k for bug-gnu-emacs@gnu.org; Tue, 23 Aug 2011 20:24:33 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:38143) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qw1Gi-0002sq-3e for bug-gnu-emacs@gnu.org; Tue, 23 Aug 2011 20:24:32 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1Qw1J8-00025U-4z; Tue, 23 Aug 2011 20:27:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 24 Aug 2011 00:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9353 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 9353-submit@debbugs.gnu.org id=B9353.13141456088002 (code B ref 9353); Wed, 24 Aug 2011 00:27:02 +0000 Original-Received: (at 9353) by debbugs.gnu.org; 24 Aug 2011 00:26:48 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qw1Iu-000251-3F for submit@debbugs.gnu.org; Tue, 23 Aug 2011 20:26:48 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.183] helo=ironport2-out.pppoe.ca) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qw1Ir-00024r-K5 for 9353@debbugs.gnu.org; Tue, 23 Aug 2011 20:26:46 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av0EAN1DVE5Ld+HZ/2dsb2JhbABCp2h4gUABAQQBViMFCws0EhQYDSSIBLx0hkgEn3eEOA X-IronPort-AV: E=Sophos;i="4.68,272,1312171200"; d="scan'208";a="132484482" Original-Received: from 75-119-225-217.dsl.teksavvy.com (HELO ceviche.home) ([75.119.225.217]) by ironport2-out.pppoe.ca with ESMTP/TLS/ADH-AES256-SHA; 23 Aug 2011 20:24:14 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id 323506610A; Tue, 23 Aug 2011 20:24:14 -0400 (EDT) In-Reply-To: (Drew Adams's message of "Tue, 23 Aug 2011 13:18:54 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Tue, 23 Aug 2011 20:27:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 1) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:50258 Archived-At: > For one thing, it should not be bold. We should almost never use a bold > face as the default face for something, because boldness does not work > well on some platforms and for some (many) faces. I tend to agree, tho in this case part of the intention of grep-mode is to make this part of the text less important since you don't need to visit the file by hand but can just click on the link instead. At least I think that's the only reason why noone complained about those faces until now, even though they've been in use at least since Emacs-23.1. > But there is also no logical connection to "success" here. I don't know what's the connection either. Maybe it's a "match success". > Anyway, whatever you inherit from (but why must you always inherit?), It's good to provide structure within the space of faces, so inheritance is an important tool that should be used whenever possible, but of course, we need to be careful to only use it when it really makes sense. AFAICT the `success' face was created pretty much for this, so maybe the problem is not the inheritance link but the name of the `success' face. > the default appearance should not be ugly and difficult to read. That > just forces more users to customize it or live with the difficulty. The default font I use is readable in bold, because giving up on such a useful tool would be too bad (remember that I prefer to use the same color everywhere and distinguish things based on bold/italics/font), but that's just me. I'm not opposed to tweaks for this face, tho a bright bold green seems to work well in M-x compile (at least for my setup), so please consider the impact on M-x compile when making those tweaks. Stefan