From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#6799: 24.0.50; Please add dired-details.el to Emacs [patch] Date: Fri, 15 Feb 2013 10:25:50 -0500 Message-ID: References: <9C9137560F644E759AD573BBBD8E59EF@us.oracle.com> <5EA47A0255F8494DB430B52D46876641@us.oracle.com> <65D921448B0644988BE6445A2EF3E021@us.oracle.com> <21FFB8EA85964411A9B790386C5DA3AD@us.oracle.com> <878v8zow44@ch.ristopher.com> <87k3sj6juj@ch.ristopher.com> <87mwxcx149@ch.ristopher.com> <87wqugmcu8@ch.ristopher.com> <87mwvbuus2@ch.ristopher.com> <87k3qeestt@ch.ristopher.com> <87ehgm7hmx@ch.ristopher.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; CHARSET=US-ASCII Content-Transfer-Encoding: 7BIT X-Trace: ger.gmane.org 1360941995 20555 80.91.229.3 (15 Feb 2013 15:26:35 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 15 Feb 2013 15:26:35 +0000 (UTC) To: 6799@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Feb 15 16:26:57 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1U6NBg-0000u2-OQ for geb-bug-gnu-emacs@m.gmane.org; Fri, 15 Feb 2013 16:26:56 +0100 Original-Received: from localhost ([::1]:33308 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U6NBN-0001Sx-3q for geb-bug-gnu-emacs@m.gmane.org; Fri, 15 Feb 2013 10:26:37 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:43030) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U6NBF-0001Sc-Ky for bug-gnu-emacs@gnu.org; Fri, 15 Feb 2013 10:26:35 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U6NB5-0001kN-SV for bug-gnu-emacs@gnu.org; Fri, 15 Feb 2013 10:26:29 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:52313) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U6NB5-0001kD-LC for bug-gnu-emacs@gnu.org; Fri, 15 Feb 2013 10:26:19 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1U6NBm-0002RZ-9z for bug-gnu-emacs@gnu.org; Fri, 15 Feb 2013 10:27:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 15 Feb 2013 15:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6799 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.13609420189382 (code B ref -1); Fri, 15 Feb 2013 15:27:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 15 Feb 2013 15:26:58 +0000 Original-Received: from localhost ([127.0.0.1]:57777 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U6NBh-0002RH-RM for submit@debbugs.gnu.org; Fri, 15 Feb 2013 10:26:58 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:59820) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U6NBd-0002R8-SL for submit@debbugs.gnu.org; Fri, 15 Feb 2013 10:26:55 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U6NAq-0001go-4g for submit@debbugs.gnu.org; Fri, 15 Feb 2013 10:26:10 -0500 Original-Received: from lists.gnu.org ([208.118.235.17]:42883) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U6NAq-0001gk-1K for submit@debbugs.gnu.org; Fri, 15 Feb 2013 10:26:04 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:42921) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U6NAk-0001EB-49 for bug-gnu-emacs@gnu.org; Fri, 15 Feb 2013 10:26:03 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U6NAe-0001eJ-4X for bug-gnu-emacs@gnu.org; Fri, 15 Feb 2013 10:25:58 -0500 Original-Received: from relais.videotron.ca ([24.201.245.36]:53485) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U6NAd-0001e9-Sd for bug-gnu-emacs@gnu.org; Fri, 15 Feb 2013 10:25:52 -0500 Original-Received: from ceviche.home ([24.201.208.110]) by VL-VM-MR002.ip.videotron.ca (Oracle Communications Messaging Exchange Server 7u4-22.01 64bit (built Apr 21 2011)) with ESMTP id <0MI9004B8PJ2S050@VL-VM-MR002.ip.videotron.ca> for bug-gnu-emacs@gnu.org; Fri, 15 Feb 2013 10:25:51 -0500 (EST) Original-Received: by ceviche.home (Postfix, from userid 20848) id BD8BB66109; Fri, 15 Feb 2013 10:25:50 -0500 (EST) In-reply-to: <87ehgm7hmx@ch.ristopher.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Solaris 10 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:71314 Archived-At: > dired-hide-details-mode also hides full lines other than header and > file/directory lines. This includes the informational line right after > the header line. > /my/directory: > total used in directory 1M available 1.0G <-- > drwx------ 2 me me 4.0K Feb 11 17:35 file Is that the only full line that it hides, or are there others? > Apply the patch, revert all hunks to dired-(next|previous)-line and move > point around the first lines of a dired buffer with hidden details. Use > C-n and C-p for point movement. AFAICT, the resulting behavior (when replacing dired-next-line's body with forward-line plus dired-move-to-filename) is slightly suboptimal, but only for that one "hidden usage line" at the top, and even then it's nothing too terrible. Thinking of how to "fix it right", I think we'd need to introduce something like a point-adjustment-function which dired-next-line could set, and would take a "direction" argument. So keyboard.c's adjust_point_for_property would call this function after adjusting point. But it seems difficult to introduce such a thing in a robust way: - We could have it as a variable, which gets cleared before running the next command, but then dired-next-line should only set it when called interactively (otherwise if the caller calls dired-next-line within, say, a save-excursion, you'd get surprising side-effects). - We could have it as a property on the `dired-next-line' symbol, but then we get the reverse problem, that a wrapper command that just calls dired-next-line and not much else would fail to get this part of dired-next-line's behavior. Maybe a cleaner solution is to export keyboard.c's adjust_point_for_property to Elisp so that dired-next-line can call it explicitly (to replace your "(while (and (invisible-p (point))) ...)" loop). Stefan