unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Juanma Barranquero <lekktu@gmail.com>
Cc: 16733@debbugs.gnu.org
Subject: bug#16733: messed up unicode chars in package description
Date: Fri, 21 Mar 2014 22:54:23 -0400	[thread overview]
Message-ID: <jwvfvmbrlop.fsf-monnier+emacsbugs@gnu.org> (raw)
In-Reply-To: <CAAeL0SSsj7YFcEF0j74RQn5HmQQsiQr5St=N=Vb=ybKzdQ+7+A@mail.gmail.com> (Juanma Barranquero's message of "Sat, 22 Mar 2014 02:33:21 +0100")

> --- lisp/url/url-handlers.el    2014-01-01 07:43:34 +0000
> +++ lisp/url/url-handlers.el    2014-03-22 01:16:06 +0000
> @@ -290,11 +290,14 @@
>        (insert data))
>      (list (length data) charset)))

> -;;;###autoload
> -(defun url-insert-file-contents (url &optional visit beg end replace)
> +(defun url-insert-file-contents-internal (check url &optional visit
> beg end replace)
>    (let ((buffer (url-retrieve-synchronously url)))
> -    (if (not buffer)
> -       (error "Opening input file: No such file or directory, %s" url))
> +    (when check
> +      (condition-case err
> +         (funcall check buffer url visit beg end replace)
> +       (error
> +        (when buffer (kill-buffer))
> +        (signal (car err) (cdr err)))))
>      (if visit (setq buffer-file-name url))
>      (save-excursion
>        (let* ((start (point))

Let's not call it "-internal" since it should be "always" preferred over
the other one.  Also, I see no need to pass "url visit beg end replace"
to "check" (if that function needs it, the caller can provide it).

Also, how 'bout only calling that `check' function in case of a problem?


        Stefan





  reply	other threads:[~2014-03-22  2:54 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-13  1:47 bug#16733: messed up unicode chars in package description Glenn Morris
2014-03-19  1:34 ` Juanma Barranquero
2014-03-19  6:26   ` Glenn Morris
2014-03-19 10:19     ` Juanma Barranquero
2014-03-19 15:53       ` Glenn Morris
2014-03-19 16:08         ` Juanma Barranquero
2014-03-19 16:16           ` Glenn Morris
2014-03-19 16:24             ` Juanma Barranquero
2014-03-19 17:11               ` Eli Zaretskii
2014-03-19 17:43                 ` Juanma Barranquero
2014-03-19 18:05                   ` Glenn Morris
2014-03-19 18:33                     ` Juanma Barranquero
2014-03-20  5:12                     ` Juanma Barranquero
2014-03-20 16:02                       ` Glenn Morris
2014-03-20 16:30                         ` Juanma Barranquero
2014-03-20 16:21                       ` Eli Zaretskii
2014-03-20 17:26                         ` Juanma Barranquero
2014-03-22  1:11                           ` Juanma Barranquero
2014-03-22  1:18                             ` Juanma Barranquero
2014-03-22  1:33                               ` Juanma Barranquero
2014-03-22  2:54                                 ` Stefan Monnier [this message]
2014-03-22  3:27                                   ` Juanma Barranquero
2014-03-22 14:33                                     ` Stefan
2014-03-22 14:43                                       ` Juanma Barranquero
2014-03-22 15:55                                         ` Stefan
2014-03-22 16:46                                           ` Juanma Barranquero
2014-03-22 18:53                                             ` Stefan
2014-03-22 19:05                                               ` Juanma Barranquero
2014-03-23 22:24                                                 ` Stefan
2014-03-25  3:04                                                   ` Juanma Barranquero
2014-03-25  3:35                                                     ` Stefan Monnier
2014-03-25  9:54                                                       ` Juanma Barranquero
2014-03-25 13:21                                                         ` Stefan Monnier
2014-03-26 15:24                                                           ` Juanma Barranquero
2014-03-22  7:25                             ` Eli Zaretskii
2014-03-22 12:20                               ` Juanma Barranquero
2014-03-22 14:31                               ` Stefan
2014-03-22 14:39                                 ` Juanma Barranquero
2014-03-22 15:02                                   ` Eli Zaretskii
2014-03-22 15:07                                     ` Juanma Barranquero
2014-03-22 15:09                                       ` Eli Zaretskii
2014-03-22 15:11                                         ` Juanma Barranquero
2014-03-19 19:00             ` Stefan
2014-03-19 19:42             ` Glenn Morris
2014-03-19 20:44               ` Juanma Barranquero
2014-03-19 17:08           ` Eli Zaretskii
2014-03-19 17:09             ` Juanma Barranquero

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvfvmbrlop.fsf-monnier+emacsbugs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=16733@debbugs.gnu.org \
    --cc=lekktu@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).