From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#17271: 24.4.50; mouse-yank-primary can insert read-only attributes Date: Wed, 02 Jul 2014 10:43:46 -0400 Message-ID: References: <87wqeql9xm.fsf@loki.jorgenschaefer.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1404312502 7915 80.91.229.3 (2 Jul 2014 14:48:22 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 2 Jul 2014 14:48:22 +0000 (UTC) Cc: 17271-done@debbugs.gnu.org, xani666@gmail.com To: Jorgen Schaefer Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jul 02 16:48:15 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1X2LpV-0005DA-Q8 for geb-bug-gnu-emacs@m.gmane.org; Wed, 02 Jul 2014 16:48:13 +0200 Original-Received: from localhost ([::1]:54147 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X2LpV-0002Vp-Cj for geb-bug-gnu-emacs@m.gmane.org; Wed, 02 Jul 2014 10:48:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48392) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X2LpK-0002Lq-01 for bug-gnu-emacs@gnu.org; Wed, 02 Jul 2014 10:48:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X2LpB-000268-Jx for bug-gnu-emacs@gnu.org; Wed, 02 Jul 2014 10:48:01 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:49410) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X2LmS-0008Cy-GX for bug-gnu-emacs@gnu.org; Wed, 02 Jul 2014 10:45:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1X2LmR-0004ba-RE for bug-gnu-emacs@gnu.org; Wed, 02 Jul 2014 10:45:03 -0400 Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Wed, 02 Jul 2014 14:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 17271 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Mail-Followup-To: 17271@debbugs.gnu.org, monnier@iro.umontreal.ca, forcer@forcix.cx Original-Received: via spool by 17271-done@debbugs.gnu.org id=D17271.140431224417556 (code D ref 17271); Wed, 02 Jul 2014 14:45:02 +0000 Original-Received: (at 17271-done) by debbugs.gnu.org; 2 Jul 2014 14:44:04 +0000 Original-Received: from localhost ([127.0.0.1]:40556 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X2LlP-0004YW-9T for submit@debbugs.gnu.org; Wed, 02 Jul 2014 10:44:04 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:36237) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X2LlI-0004Y4-Ot for 17271-done@debbugs.gnu.org; Wed, 02 Jul 2014 10:43:57 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ArYGAIDvNVNLd+D9/2dsb2JhbABZgwaDSr0vgw6BFxd0giUBAQEBAgFWIwULCw4mEhQYDSSIBAjSGReOegeEOASpGYFqg0wh X-IPAS-Result: ArYGAIDvNVNLd+D9/2dsb2JhbABZgwaDSr0vgw6BFxd0giUBAQEBAgFWIwULCw4mEhQYDSSIBAjSGReOegeEOASpGYFqg0wh X-IronPort-AV: E=Sophos;i="4.97,753,1389762000"; d="scan'208";a="75729377" Original-Received: from 75-119-224-253.dsl.teksavvy.com (HELO pastel.home) ([75.119.224.253]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 02 Jul 2014 10:43:46 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 769B762F8B; Wed, 2 Jul 2014 10:43:46 -0400 (EDT) In-Reply-To: <87wqeql9xm.fsf@loki.jorgenschaefer.de> (Jorgen Schaefer's message of "Tue, 15 Apr 2014 20:33:25 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:91098 Archived-At: Version:24.4 > Then select the "foo" and immediately yank it somewhere using the middle > mouse button. The inserted text retains the read-only property. > > It probably would be a good idea for `mouse-yank-primary' to use > `insert-for-yank' instead of `insert'. Indeed, thanks. I installed the patch below into the `emacs-24' branch. Stefan === modified file 'lisp/mouse.el' --- lisp/mouse.el 2014-06-20 18:35:04 +0000 +++ lisp/mouse.el 2014-07-02 14:37:36 +0000 @@ -1101,7 +1101,7 @@ (unless primary (error "No selection is available")) (push-mark (point)) - (insert primary))) + (insert-for-yank primary))) (defun mouse-kill-ring-save (click) "Copy the region between point and the mouse click in the kill ring. @@ -1383,7 +1383,7 @@ (or mouse-yank-at-point (mouse-set-point click)) (let ((secondary (x-get-selection 'SECONDARY))) (if secondary - (insert secondary) + (insert-for-yank secondary) (error "No secondary selection")))) (defun mouse-kill-secondary ()