unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: martin rudalics <rudalics@gmx.at>
Cc: 6130@debbugs.gnu.org, busk <busk@lysator.liu.se>,
	Daniel Koning <dk@danielkoning.com>
Subject: bug#6130: 23.1; artist-mode spray-can malfunction
Date: Thu, 22 Jan 2015 18:08:36 -0500	[thread overview]
Message-ID: <jwvfvb28lnv.fsf-monnier+emacsbugs@gnu.org> (raw)
In-Reply-To: <54C1402D.1000100@gmx.at> (martin rudalics's message of "Thu, 22 Jan 2015 19:23:41 +0100")

> Daniel in his first post wrote that
>   I also went ahead and searched the lisp/ tree for other places that
>   looked risky -- that is, where a position object was assumed to hold a
>   window in a context where there was no such guarantee. Nothing jumped
>   out at me, but there could be any number of issues with third-party
>   code.
> so I think this has been taken care of already.

To be honest, I don't know what that means.  IIUC it means that most of
the code doesn't care if posn-window sometimes returns a frame.

It's wrong for posn-window to return a frame.  So are there callers that
actually rely on this wrong behavior?  Are there callers where returning
nil instead of a frame would be a problem?  Are there callers where
signaling an error instead of returning a frame would be a problem?

> This would backfire for people who would like `posn-window' to always
> return the first element of a position.

That's OK, in the sense that we don't care if people's feelings
are hurt.  But if it breaks existing packages it's more problematic.


        Stefan





  reply	other threads:[~2015-01-22 23:08 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-07 12:17 bug#6130: 23.1; artist-mode spray-can malfunction busk
2015-01-17  5:25 ` Daniel Koning
2015-01-17 13:56   ` martin rudalics
2015-01-18  5:47     ` Daniel Koning
2015-01-18  9:57       ` martin rudalics
2015-01-21  0:26         ` Daniel Koning
2015-01-21  8:22           ` martin rudalics
2015-01-21 15:22           ` Stefan Monnier
2015-01-21 16:54             ` martin rudalics
2015-01-22 17:02               ` Stefan Monnier
2015-01-22 18:23                 ` martin rudalics
2015-01-22 23:08                   ` Stefan Monnier [this message]
2015-01-23  8:26                     ` martin rudalics
2015-01-23  9:43                       ` Eli Zaretskii
2015-01-23 16:54                         ` martin rudalics
2015-01-23 21:05                           ` Stefan Monnier
2015-01-23 21:26                             ` Eli Zaretskii
2015-01-23 21:52                               ` Daniel Koning
2015-01-24  8:12                                 ` Eli Zaretskii
2015-01-24  9:08                                   ` martin rudalics
2015-01-24  9:49                                     ` Eli Zaretskii
2016-04-06  9:17 ` Johan Busk Eriksson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvfvb28lnv.fsf-monnier+emacsbugs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=6130@debbugs.gnu.org \
    --cc=busk@lysator.liu.se \
    --cc=dk@danielkoning.com \
    --cc=rudalics@gmx.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).