From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#20357: 25.0.50; deactivate-mark behavior broken Date: Fri, 17 Apr 2015 15:15:58 -0400 Message-ID: References: <87pp735a42.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1429298252 14266 80.91.229.3 (17 Apr 2015 19:17:32 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 17 Apr 2015 19:17:32 +0000 (UTC) Cc: 20357-done@debbugs.gnu.org To: Oleh Krehel Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Apr 17 21:17:20 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YjBlI-000510-US for geb-bug-gnu-emacs@m.gmane.org; Fri, 17 Apr 2015 21:17:13 +0200 Original-Received: from localhost ([::1]:43229 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YjBlI-0007g1-1R for geb-bug-gnu-emacs@m.gmane.org; Fri, 17 Apr 2015 15:17:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50840) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YjBlD-0007fX-Uy for bug-gnu-emacs@gnu.org; Fri, 17 Apr 2015 15:17:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YjBl8-0004dY-Ql for bug-gnu-emacs@gnu.org; Fri, 17 Apr 2015 15:17:07 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:41332) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YjBl8-0004dT-NV for bug-gnu-emacs@gnu.org; Fri, 17 Apr 2015 15:17:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YjBl8-0000Dv-8z for bug-gnu-emacs@gnu.org; Fri, 17 Apr 2015 15:17:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 17 Apr 2015 19:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20357 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20357-done@debbugs.gnu.org id=D20357.1429298165782 (code D ref 20357); Fri, 17 Apr 2015 19:17:02 +0000 Original-Received: (at 20357-done) by debbugs.gnu.org; 17 Apr 2015 19:16:05 +0000 Original-Received: from localhost ([127.0.0.1]:59340 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YjBkC-0000CY-Il for submit@debbugs.gnu.org; Fri, 17 Apr 2015 15:16:04 -0400 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:60592) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YjBk8-0000C2-Qz for 20357-done@debbugs.gnu.org; Fri, 17 Apr 2015 15:16:02 -0400 Original-Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id t3HJFwiG007453; Fri, 17 Apr 2015 15:15:59 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 395E11178; Fri, 17 Apr 2015 15:15:58 -0400 (EDT) In-Reply-To: (Oleh Krehel's message of "Fri, 17 Apr 2015 20:30:14 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV5279=0 X-NAI-Spam-Version: 2.3.0.9393 : core <5279> : inlines <2749> : streams <1424113> : uri <1909324> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:101651 Archived-At: >>> (with-temp-buffer >>> (insert "foobar") >>> (set-mark (point)) >>> (goto-char (point-min)) >>> (indent-region (point-min) >>> (point-max)) >>> mark-active) >>> In 24.5 it returns nil, which is correct. While in 25 it returns t. >> Why is it more correct to return nil than to return t? > Because it's a long standing behavior that if you mark some stuff and > press TAB, the mark will be deactivated. That's still the case. The difference is that now it's deactivated by the command loop rather than by the command itself. Doing it in the command loop is the normal behavior (the one used for most other commands which cause the mark to be deactivated). >>> This is a recent change, 24.5.2 doesn't have this bug. >>> (let (deactivate-mark) >>> (indent-region (region-beginning) >>> (region-end))) >>> Expected behavior: the mark isn't deactivated. >> At least in 24.4, the mark does get deactivated in my test. It's also deactivated in Emacs-23.4 in my tests. > But when I've tested with 24.5 or 25 on my own machine, the tests were > running fine. I think we need to know more about what your tests really do. Maybe they should just be fixed to test (or (not mark-active) deactivate-mark) instead of only testing mark-active. Stefan