From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: 10085@debbugs.gnu.org
Subject: bug#10085: 24.0.91; completion-pcm--find-all-completions returns wrong remote file names
Date: Wed, 27 Apr 2016 10:16:30 -0400 [thread overview]
Message-ID: <jwvfuu79mua.fsf-monnier+bug#10085@gnu.org> (raw)
In-Reply-To: <87k46qwpl2.fsf@gmx.de> (Michael Albinus's message of "Wed, 23 Nov 2011 21:28:41 +0100")
> Tramp does not know of programmed completion and pcm style completion;
> all what it knows is file-name-all-completions.
> What else could Tramp do?
Tramp has control via file-name-directory.
>>> I guess we need to find out, what are separators in Tramp wrt
>>> completion tables, and how to handle them.
>> The user finds out, the implementer decides.
> Oh. You haven't seen Tramp's heuristic to determine, whether completion
> of "/sudo" means the method or the user or the host (in fact, it is all).
;-)
OK, here are some inconsistencies I found just now in emacs-25:
ELISP> (completion-boundaries "/sudo:" #'completion-file-name-table nil "")
(6 . 0)
ELISP> (let ((non-essential t)) (completion-boundaries "/sudo:" #'completion-file-name-table nil ""))
(1 . 0)
In the above the first answer looks good to me.
The second looks wrong: it should be the same as the first.
This is controlled by Tramp via (file-name-directory "/sudo:").
ELISP> (all-completions "/sudo:" #'completion-file-name-table)
*** Eval error *** Host name must not match method "sudo"
ELISP> (let ((non-essential t)) (all-completions "/sudo:" #'completion-file-name-table))
("sudo:root@")
The first answer above looks wrong (there's no reason for Tramp to
assume that "/sudo:" uses "sudo" as a host name, and indeed in the
second case it correctly interprets "sudo" as a method rather than
a host name).
Assuming we fix the completion-boundaries to be (6 . 0) the second
answer (which comes from `file-name-all-completions "" "/sudo:") should
be ("root@").
Fixing those inconsistencies should fix bug#10085.
Stefan
next prev parent reply other threads:[~2016-04-27 14:16 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-20 15:58 bug#10085: 24.0.91; completion-pcm--find-all-completions returns wrong remote file names Michael Albinus
2011-11-22 17:04 ` Stefan Monnier
2011-11-22 22:13 ` Michael Albinus
2011-11-22 23:05 ` Stefan Monnier
2011-11-23 6:43 ` Michael Albinus
2011-11-23 14:04 ` Stefan Monnier
2011-11-23 20:28 ` Michael Albinus
2011-11-24 2:10 ` Stefan Monnier
2016-04-27 14:16 ` Stefan Monnier [this message]
2016-04-27 18:37 ` Michael Albinus
2016-04-27 19:16 ` Stefan Monnier
2016-05-02 7:19 ` Michael Albinus
2011-11-22 19:05 ` Stefan Monnier
2011-11-22 21:55 ` Michael Albinus
2012-03-30 18:28 ` Stefan Monnier
2012-03-31 12:36 ` Michael Albinus
2012-03-31 15:29 ` Stefan Monnier
2016-04-23 20:08 ` bug#10085: Tramp method completions Live System User
2016-04-24 8:22 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='jwvfuu79mua.fsf-monnier+bug#10085@gnu.org' \
--to=monnier@iro.umontreal.ca \
--cc=10085@debbugs.gnu.org \
--cc=michael.albinus@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).