From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#23917: Please consider making Bug #23917 a blocker for 25.1 (was Re: org-capture: Capture template =?UTF-8?Q?=E2=80=98g=E2=80=99:?= Match data clobbered by buffer modification hooks) Date: Wed, 20 Jul 2016 14:19:59 -0400 Message-ID: References: <87vb066ejv.fsf@linaro.org> <8360s67qcp.fsf@gnu.org> <87bn1yyaui.fsf@linaro.org> <87mvlhmv0x.fsf_-_@moondust.awandering> <837fcl5zs9.fsf@gnu.org> <87a8hgkwcb.fsf@linaro.org> <8360s42mcb.fsf@gnu.org> <87eg6rgmlg.fsf@gmail.com> <83lh0y24y6.fsf@gnu.org> <83eg6q1hbo.fsf@gnu.org> <83a8hd1vzi.fsf@gnu.org> <834m7l1u8u.fsf@gnu.org> <83shv4z7e8.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1469041000 19889 80.91.229.3 (20 Jul 2016 18:56:40 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 20 Jul 2016 18:56:40 +0000 (UTC) Cc: nljlistbox2@gmail.com, npostavs@users.sourceforge.net, jwiegley@gmail.com, rpluim@gmail.com, 23917@debbugs.gnu.org, alex.bennee@linaro.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jul 20 20:56:31 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bPwfV-0001n0-7h for geb-bug-gnu-emacs@m.gmane.org; Wed, 20 Jul 2016 20:56:29 +0200 Original-Received: from localhost ([::1]:36461 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bPwfU-0006rr-8Z for geb-bug-gnu-emacs@m.gmane.org; Wed, 20 Jul 2016 14:56:28 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54842) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bPw7J-0000s8-RI for bug-gnu-emacs@gnu.org; Wed, 20 Jul 2016 14:21:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bPw7H-0006ay-U2 for bug-gnu-emacs@gnu.org; Wed, 20 Jul 2016 14:21:08 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:46570) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bPw7C-0006Yu-EG; Wed, 20 Jul 2016 14:21:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bPw7C-0000Dr-Ax; Wed, 20 Jul 2016 14:21:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, emacs-orgmode@gnu.org Resent-Date: Wed, 20 Jul 2016 18:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23917 X-GNU-PR-Package: emacs,org-mode X-GNU-PR-Keywords: Original-Received: via spool by 23917-submit@debbugs.gnu.org id=B23917.1469038808757 (code B ref 23917); Wed, 20 Jul 2016 18:21:02 +0000 Original-Received: (at 23917) by debbugs.gnu.org; 20 Jul 2016 18:20:08 +0000 Original-Received: from localhost ([127.0.0.1]:58907 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bPw6K-0000C8-1K for submit@debbugs.gnu.org; Wed, 20 Jul 2016 14:20:08 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:18698) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bPw6I-0000BX-Ok for 23917@debbugs.gnu.org; Wed, 20 Jul 2016 14:20:07 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0CnDgA731xV/3mcpUVcgxCEAgjIWAICAQECgTw8EQEBAQEBAQGBCkEFg10BAQMBDEojBQsJAjQHCxQYDRMRLogJCI18wScBAQEBBgEBAQEeizqFBQeELQWfF4NrkD2BRSOCO4FZIoJ4AQEB X-IPAS-Result: A0CnDgA731xV/3mcpUVcgxCEAgjIWAICAQECgTw8EQEBAQEBAQGBCkEFg10BAQMBDEojBQsJAjQHCxQYDRMRLogJCI18wScBAQEBBgEBAQEeizqFBQeELQWfF4NrkD2BRSOCO4FZIoJ4AQEB X-IronPort-AV: E=Sophos;i="5.13,465,1427774400"; d="scan'208";a="248685461" Original-Received: from 69-165-156-121.dsl.teksavvy.com (HELO pastel.home) ([69.165.156.121]) by ironport2-out.teksavvy.com with ESMTP; 20 Jul 2016 14:20:00 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id CA7DF64CAE; Wed, 20 Jul 2016 14:19:59 -0400 (EDT) In-Reply-To: <83shv4z7e8.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 20 Jul 2016 17:55:11 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:121327 Archived-At: > Is it OK to adjust the match data before actually making the > replacement? If so, I think it's a simpler solution. >> PS: I can think of one (theoretical) other/better way to fix this >> problem: move the match-data adjustment so it's done within >> replace_range before running the after-change-functions. > Isn't that almost the same as what Noam suggested? Yes, it's the same. And yes, I like the idea, but I just don't know what it would look like as a patch. I have the impression that it could prove either expensive in CPU time and backward incompatible (e.g. adjust markers for every buffer modification), or require extensive code surgery and/or breaking some abstractions. This is just an impression, tho. I think it'd definitely be the better solution, so it's worth investigating anyway, if only for "master" rather than for "emacs-25". Stefan