unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: 24047@debbugs.gnu.org
Subject: bug#24047: Should 'signal' sometimes return?
Date: Sat, 23 Jul 2016 14:37:36 -0400	[thread overview]
Message-ID: <jwvfur02oex.fsf-monnier+bug#24047@gnu.org> (raw)
In-Reply-To: <f66fb97a-0322-b71f-98d2-5e58cbd4419b@cs.ucla.edu> (Paul Eggert's message of "Fri, 22 Jul 2016 14:16:58 +0200")

> Attached is a more-conservative version of the patch, which keeps the
> debug-on-quit behavior when the user types C-g, so that 'signal' never
> returns but C-g might still "return". This is in response to Stefan's email
> at <http://lists.gnu.org/archive/html/emacs-devel/2016-07/msg00958.html>.

Haven't looked in detail, but it looks OK.

A further patch could change the new `quit' function so it checks
debug-on-quit, and either calls the debugger or calls Fsignal.  This way
we don't need the intermediate signal_or_quit function.


        Stefan





  reply	other threads:[~2016-07-23 18:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-21 14:20 bug#24047: [PROPOSED PATCH] ‘signal’ no longer returns Paul Eggert
2016-07-22 12:16 ` bug#24047: Should 'signal' sometimes return? Paul Eggert
2016-07-23 18:37   ` Stefan Monnier [this message]
2016-07-24 22:42     ` Paul Eggert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='jwvfur02oex.fsf-monnier+bug#24047@gnu.org' \
    --to=monnier@iro.umontreal.ca \
    --cc=24047@debbugs.gnu.org \
    --cc=eggert@cs.ucla.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).