From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#28587: 26.0.60; Don't write object name strings in object-write method Date: Wed, 08 Nov 2017 15:31:07 -0500 Message-ID: References: <87efqvg5tw.fsf@ericabrahamsen.net> <87o9octu8m.fsf@ericabrahamsen.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1510173014 10332 195.159.176.226 (8 Nov 2017 20:30:14 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 8 Nov 2017 20:30:14 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 28587@debbugs.gnu.org To: Eric Abrahamsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Nov 08 21:30:10 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eCWzB-0002UL-5J for geb-bug-gnu-emacs@m.gmane.org; Wed, 08 Nov 2017 21:30:09 +0100 Original-Received: from localhost ([::1]:33801 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eCWzI-0007dB-JV for geb-bug-gnu-emacs@m.gmane.org; Wed, 08 Nov 2017 15:30:16 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53786) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eCWz8-0007ad-Bo for bug-gnu-emacs@gnu.org; Wed, 08 Nov 2017 15:30:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eCWz5-0008VB-0q for bug-gnu-emacs@gnu.org; Wed, 08 Nov 2017 15:30:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:50273) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eCWz4-0008Uz-UH for bug-gnu-emacs@gnu.org; Wed, 08 Nov 2017 15:30:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eCWz4-0004jv-Ke for bug-gnu-emacs@gnu.org; Wed, 08 Nov 2017 15:30:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 08 Nov 2017 20:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28587 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 28587-submit@debbugs.gnu.org id=B28587.151017299418186 (code B ref 28587); Wed, 08 Nov 2017 20:30:02 +0000 Original-Received: (at 28587) by debbugs.gnu.org; 8 Nov 2017 20:29:54 +0000 Original-Received: from localhost ([127.0.0.1]:58954 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eCWyw-0004jG-AR for submit@debbugs.gnu.org; Wed, 08 Nov 2017 15:29:54 -0500 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:33809) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eCWyt-0004j6-SQ for 28587@debbugs.gnu.org; Wed, 08 Nov 2017 15:29:52 -0500 Original-Received: from lechazo.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id vA8KTot2004730; Wed, 8 Nov 2017 15:29:51 -0500 Original-Received: by lechazo.home (Postfix, from userid 20848) id DF707605C1; Wed, 8 Nov 2017 15:31:07 -0500 (EST) In-Reply-To: <87o9octu8m.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Wed, 08 Nov 2017 12:01:45 -0800") X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV6154=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6154> : inlines <6166> : streams <1769725> : uri <2530500> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:139631 Archived-At: > So where we're at now is, the previous chunk has gone into both master > and emacs-26. Yay! > The next patch (below) would only go into master, so as to > be more conservative about what's emitted. Everything defaults to > current behavior. Looks good, except for: > + "When non-nil write the object name in `object-write'. > +Does not affect objects subclassing `eieio-named'. Writing > +object names is deprecated as of Emacs 24.4; consider setting > +this to nil.") AFAIK names are deprecated in calls to EIEIO constructors since Emacs-25 (rather 24.4), and it's only since Emacs-26 that they are optional in "eieio-presistent" written representations. Stefan