From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#30190: 27.0.50; term run in line mode shows user passwords Date: Thu, 21 Jun 2018 15:17:19 -0400 Message-ID: References: <87r2qjh0fs.fsf@gmail.com> <87mv17nwe4.fsf@users.sourceforge.net> <87efm259s5.fsf@gmail.com> <83vafe9f16.fsf@gnu.org> <87wozfkt9t.fsf@gmail.com> <87o9kiejd4.fsf@gmail.com> <83606q6xr7.fsf@gnu.org> <873718qpme.fsf@gmail.com> <87in6erte5.fsf@gmail.com> <83efh1s9s3.fsf@gnu.org> <87602drqan.fsf@gmail.com> <8336xgsvt3.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1529608566 7904 195.159.176.226 (21 Jun 2018 19:16:06 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 21 Jun 2018 19:16:06 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 30190@debbugs.gnu.org, Noam Postavsky To: Tino Calancha Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jun 21 21:16:01 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fW53p-0001vJ-Eh for geb-bug-gnu-emacs@m.gmane.org; Thu, 21 Jun 2018 21:16:01 +0200 Original-Received: from localhost ([::1]:57269 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fW55w-0008Jz-QJ for geb-bug-gnu-emacs@m.gmane.org; Thu, 21 Jun 2018 15:18:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47725) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fW55p-0008Jr-8f for bug-gnu-emacs@gnu.org; Thu, 21 Jun 2018 15:18:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fW55m-0001xQ-2i for bug-gnu-emacs@gnu.org; Thu, 21 Jun 2018 15:18:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:51478) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fW55l-0001xD-UZ for bug-gnu-emacs@gnu.org; Thu, 21 Jun 2018 15:18:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fW55l-00089n-K4 for bug-gnu-emacs@gnu.org; Thu, 21 Jun 2018 15:18:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 21 Jun 2018 19:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30190 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed security Original-Received: via spool by 30190-submit@debbugs.gnu.org id=B30190.152960864331306 (code B ref 30190); Thu, 21 Jun 2018 19:18:01 +0000 Original-Received: (at 30190) by debbugs.gnu.org; 21 Jun 2018 19:17:23 +0000 Original-Received: from localhost ([127.0.0.1]:59375 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fW558-00088s-Vo for submit@debbugs.gnu.org; Thu, 21 Jun 2018 15:17:23 -0400 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:45962) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fW557-00088k-Hq for 30190@debbugs.gnu.org; Thu, 21 Jun 2018 15:17:22 -0400 Original-Received: from ceviche.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id w5LJHpqB020025; Thu, 21 Jun 2018 15:17:51 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id 2AF7D6611F; Thu, 21 Jun 2018 15:17:19 -0400 (EDT) In-Reply-To: (Tino Calancha's message of "Thu, 21 Jun 2018 12:07:55 +0900 (JST)") X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV6313=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6313> : inlines <6711> : streams <1790352> : uri <2661954> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:147712 Archived-At: > I have the bias/personal-preference to avoid load new things when > I make a change. Let's call it: 'disturb the least' with my patches. I'd prefer to re-use comint code rather than copy it. Copying might be tolerable for term-watch-for-password-prompt (it could conceivably require adjustments for the context of term-mode), but it's out of the question for term-password-prompt-regexp. > My patch just tried to mimic what is done in `comint.el' and reproduce > it in `term.el'. My hope was that the patch would be accepted frictionless: > if it's already done in `comint.el', why not doing the same in `term.el'? I'm not a great fan of the hooks in comint (tho I must say I haven't come up with anything really better either). And to the extent that you can set *-password-prompt-regexp buffer-locally in order to prevent *-watch-for-password-prompt from getting in the way, I don't see much benefit of going through a hook. [ The hook might be beneficial in itself, with a nil default value, but that's a different discussion. ] Stefan