unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: 34322@debbugs.gnu.org
Subject: bug#34322: reproducibility: absolute file name in tramp.elc
Date: Tue, 05 Feb 2019 15:41:44 -0500	[thread overview]
Message-ID: <jwvftt2as7v.fsf-monnier+emacsbugs@gnu.org> (raw)
In-Reply-To: <87pns6uo1t.fsf@gmx.de> (Michael Albinus's message of "Tue, 05 Feb 2019 18:45:34 +0100")

>> Here you can see that there is no nested bytecode object (i.e. no
>> #[...] with the main #[...]) so the call has been correctly inlined.
> Given, that the absolute file name is not needed in the bytecode,

It's present in the in-memory bytecode object so that `C-h f` can jump
to the source upon demand, so it is needed.

> I'm wondering why we insert it there.

It's because we just insert the bytecode object wholesale (not a copy of
the object), so it comes with all its fields.

> Couldn't we live without?

We'd have to make a copy of the bytecode object, skipping the
source-code reference.

But really, this is actually a side-problem: the inlined bytecode is not
spliced the way it should, so the inlining optimization is basically
missing.  Such a half-assed inlining gives you all the downsides of
inlining without its upsides.  Once we fix that, the reproducibility
problem will also be fixed.


        Stefan





  reply	other threads:[~2019-02-05 20:41 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-04 22:58 bug#34322: reproducibility: absolute file name in tramp.elc Glenn Morris
2019-02-05  9:00 ` Michael Albinus
2019-02-05 16:18   ` Eli Zaretskii
2019-02-05 16:36     ` Stefan Monnier
2019-02-05 17:45       ` Michael Albinus
2019-02-05 20:41         ` Stefan Monnier [this message]
2021-08-11 19:14           ` bug#34322: bug#34321: reproducibility: absolute file name in newst-treeview.elc Lars Ingebrigtsen
2019-02-05 16:14 ` bug#34322: reproducibility: absolute file name in tramp.elc Eli Zaretskii
  -- strict thread matches above, loose matches on Subject: below --
2019-02-04 22:55 bug#34321: reproducibility: absolute file name in newst-treeview.elc Glenn Morris
2022-01-29 15:15 ` bug#34322: reproducibility: absolute file name in tramp.elc Lars Ingebrigtsen
2022-01-29 17:40   ` bug#34321: " Glenn Morris
2022-01-30 15:54     ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvftt2as7v.fsf-monnier+emacsbugs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=34322@debbugs.gnu.org \
    --cc=michael.albinus@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).