From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#46834: 28.0.50; byte-compiling the standard counter closure fails Date: Mon, 01 Mar 2021 11:15:05 -0500 Message-ID: References: <8735xf8154.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4189"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 46834@debbugs.gnu.org, Lars Ingebrigtsen To: Pip Cet Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Mar 01 17:18:24 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lGlFW-0000vz-VH for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 01 Mar 2021 17:18:22 +0100 Original-Received: from localhost ([::1]:58402 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lGlFV-0001Hr-A1 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 01 Mar 2021 11:18:21 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44820) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lGlDG-0005wk-MX for bug-gnu-emacs@gnu.org; Mon, 01 Mar 2021 11:16:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39027) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lGlDG-0004eT-AJ for bug-gnu-emacs@gnu.org; Mon, 01 Mar 2021 11:16:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lGlDG-0004xT-6B for bug-gnu-emacs@gnu.org; Mon, 01 Mar 2021 11:16:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 01 Mar 2021 16:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46834 X-GNU-PR-Package: emacs Original-Received: via spool by 46834-submit@debbugs.gnu.org id=B46834.161461532016743 (code B ref 46834); Mon, 01 Mar 2021 16:16:02 +0000 Original-Received: (at 46834) by debbugs.gnu.org; 1 Mar 2021 16:15:20 +0000 Original-Received: from localhost ([127.0.0.1]:50573 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lGlCa-0004Lf-Fo for submit@debbugs.gnu.org; Mon, 01 Mar 2021 11:15:20 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:42483) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lGlCZ-0004Ew-Go for 46834@debbugs.gnu.org; Mon, 01 Mar 2021 11:15:19 -0500 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id DB44A10022E; Mon, 1 Mar 2021 11:15:13 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id A317B100091; Mon, 1 Mar 2021 11:15:07 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1614615307; bh=mhD7LbKQ9vGnmMyi1Q671Vu1qWtEipimvD1+I5e5KO0=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=Mu4vJ7IO423Y1Xo/jEdXJ82ESDu93YChI6H3+xXGlRjR1kpfTA5dlbcp4NHLINoSl iioSmNbpl0oV0+7IUcC5x+dDFq/7/RF3sPoEbJsSgVgfW3+dicksHTnFYrSLZRO5oX 4o5bFAuK4q187YK/pmEXqGeRdnCIWu6Gd4c7NmF7eC5K+wjOk2KJxvb7j+1sj8IGuo /RLqub4thkz/jqpuu3zot5SyX8FJF6HdmN+8B5rgshrt2zEAYVnaR5u6WIrRND8LkC lDLGaSTb92sTeGv1qNTc4aVnuT1ISWXbh3UdmWqtLZdLStzDUlOBJqbE78ivFA2C15 HwVLW7d7sSC/Q== Original-Received: from alfajor (unknown [216.154.41.47]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id F3260120377; Mon, 1 Mar 2021 11:15:06 -0500 (EST) In-Reply-To: (Pip Cet's message of "Mon, 1 Mar 2021 15:16:22 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:201121 Archived-At: >> and notice that the counter is not shared between the two functions :-( > I'd noticed that, but figured Stefan wouldn't accept "partial byte > compilation" as a reasonable bug scenario :-) I'd have to ask him, but he'd probably roll his eyes and complain about this use case yet again. > That said, the comment in byte-compile--reify-function is incorrect: [ I don't see which comment you're referring to. ] > since closures use alists and "let" uses proper lists, we can't share > structure between them, so the return value will be equivalent to a > snapshot of FUN, not "equal" to FUN itself. OTOH, even changing that > wouldn't help as byte-compiled closures use a third format to store > the bindings, IIUC. I think we could make the shared state work if we turned (closure ((VAR . VAL) ...) ...) into something like (cl-symbol-macrolet ((VAR (cdr ',CONSCELL)) ...) ...) I find the idea pretty repulsive, tho. > I've been meaning to ask, is there anything like an XFAIL test in our > current framework? This would be an excellent use for one of those. I don't know what is XFAIL, and I'm not very knowledgeable about our test infrastructure, so you might want to ask elsewhere. Stefan