From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#57727: 29.0.50; Optimize tty display updates Date: Sun, 11 Sep 2022 09:49:11 -0400 Message-ID: References: Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21511"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 57727@debbugs.gnu.org To: Gerd =?UTF-8?Q?M=C3=B6llmann?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Sep 11 15:50:17 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oXNLl-0005R3-Kp for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 11 Sep 2022 15:50:17 +0200 Original-Received: from localhost ([::1]:43980 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oXNLk-0002I1-Lb for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 11 Sep 2022 09:50:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50244) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oXNLX-0002Fy-4V for bug-gnu-emacs@gnu.org; Sun, 11 Sep 2022 09:50:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52446) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oXNLW-0007ka-7j for bug-gnu-emacs@gnu.org; Sun, 11 Sep 2022 09:50:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oXNLV-0007wq-Vt for bug-gnu-emacs@gnu.org; Sun, 11 Sep 2022 09:50:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 11 Sep 2022 13:50:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57727 X-GNU-PR-Package: emacs Original-Received: via spool by 57727-submit@debbugs.gnu.org id=B57727.166290416130480 (code B ref 57727); Sun, 11 Sep 2022 13:50:01 +0000 Original-Received: (at 57727) by debbugs.gnu.org; 11 Sep 2022 13:49:21 +0000 Original-Received: from localhost ([127.0.0.1]:41145 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oXNKr-0007vX-BH for submit@debbugs.gnu.org; Sun, 11 Sep 2022 09:49:21 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:23599) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oXNKq-0007vB-3j for 57727@debbugs.gnu.org; Sun, 11 Sep 2022 09:49:20 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 47994440611; Sun, 11 Sep 2022 09:49:14 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id BE17C4401FE; Sun, 11 Sep 2022 09:49:12 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1662904152; bh=FMzTJTSsE/L/EgEzPWLDRWwJnrFiZcERVDXKw0JKL9w=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=WcxFJCsTO/PZk+6l2e5o0FkGaJN6wJ0acy2n+qc26Fs06N5E5N8Quk1VFnlg7tMoV TYMu4ky4oKecL2xo7jrkI8tq6ZALS3ZQCSEIdu+ihmzbuEiZaG3V9U6doN/xoHx+FC /DHHCWMI1DITEQNnNdxDrUhrnAfIBPIHjUBfBUeu0BhRY4jJdE/O5/9Abdroz+wGKj U1HbLnStEHO3mRLIwV43X0bWxUHZ/SKDTOSQUxam8NGqoDFtcUwrBhkdZFcPPTuX86 T0p0Dl3n94hA87dZsIcFgj2qtFwkiw7v7KQHWIqUoXwkodLjWwHwPHcAfwNe8kyoJU Phv0cssB0XLHA== Original-Received: from pastel (unknown [157.52.9.190]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 70ED9120909; Sun, 11 Sep 2022 09:49:12 -0400 (EDT) In-Reply-To: ("Gerd =?UTF-8?Q?M=C3=B6llmann?="'s message of "Sun, 11 Sep 2022 12:03:45 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:242168 Archived-At: > +DEFUN ("tty--set-output-buffer-size", Ftty__set_output_buffer_size, > + Stty__set_output_buffer_size, 1, 2, 0, doc: > + /* Set the output buffer size for a TTY. > + > +SIZE zero means use the system's default value. If SIZE is > +non-zero,this also avoids flushing the output stream. ^^ SPC > +TTY may be a terminal object, a frame, or nil (meaning the selected > +frame's terminal). > + > +This function temporarily suspends and resumes the terminal > +device. */) > + (Lisp_Object size, Lisp_Object tty) > +{ > + if (!TYPE_RANGED_FIXNUMP (size_t, size)) > + error ("Invalid output buffer size"); > + Fsuspend_tty(tty); ^^ SPC > + struct terminal *terminal = decode_tty_terminal (tty); > + terminal->display_info.tty->output_buffer_size > + = XFIXNUM (size) <= 0 ? 0 : XFIXNUM (size); > + return Fresume_tty(tty); ^^ SPC That seems a bit over-engineered to me. Why not just a DEVAR_BOOL to control whether we flush or not? If someone wants to try out different buffer sizes, I suspect that recompiling is a good enough solution (or provide a DEFVAR_INT for that and let the tester(s) call `suspend/resume-tty` by hand). Stefan