unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Stefan Kangas <stefankangas@gmail.com>
Cc: John Wiegley <johnw@newartisans.com>, 59914@debbugs.gnu.org
Subject: bug#59914: [GNU ELPA] Make use-package and bind-key into :core packages
Date: Fri, 09 Dec 2022 09:56:14 -0500	[thread overview]
Message-ID: <jwvfsdo8wna.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <CADwFkm=eW5Z=Ab4TZDwTcUJironJmJg=6sa+EhmwvcjRWNW6xA@mail.gmail.com> (Stefan Kangas's message of "Thu, 8 Dec 2022 16:11:22 -0800")

> Stefan, does this look okay and make sense to you?  Is pushing this all
> that is needed, or do we need some manual intervention in addition?

I think it will require manual intervention on `elpa.gnu.org` but I'll
take care of that.

> - ("bind-key"         :url "https://github.com/jwiegley/use-package"
> -  :ignored-files ("LICENSE" "doc" "Makefile*" "bind-chords.el" "use-package*"
> -                  "README.md" "NEWS.md") ;; These two are for use-package.
> -  :news "/dev/null"           ;l Don't use use-package' s `NEWS.md`.
> -  :auto-sync t)
> + ("bind-key"            :core "lisp/use-package/bind-key.el")

Looks fine.

> - ("use-package"		:url "https://github.com/jwiegley/use-package"
> -  :ignored-files ("LICENSE" "bind-*" "use-package-chords.el")
> -  :readme "README.md"
> -  :doc "use-package.texi"
> -  :news "NEWS.md"
> -  :auto-sync t)
> + ("use-package"
> +  :core ("lisp/use-package/use-package-core.el"
> +         "lisp/use-package/use-package-delight.el"
> +         "lisp/use-package/use-package-diminish.el"
> +         "lisp/use-package/use-package-ensure.el"
> +         "lisp/use-package/use-package-jump.el"
> +         "lisp/use-package/use-package-lint.el"
> +         "lisp/use-package/use-package.el")
> +  :doc "use-package.texi")

Can we use "lisp/use-package/" (and maybe the use `:ignored-files` to
strip out `bind-keys.el` or maybe even move `bind-keys.el` outside of
the `use-package` subdirectory)?

Also I suspect you need to add "doc/misc/use-package.texi" to `:core` in
order for the `:doc` to find the file.  Have you tried the above recipe?

> + ("use-package-ensure-system-package"
> +  :core ("lisp/use-package/use-package-ensure-system-package.el"))

Why do we need this as a separate package?

And while I'm here, I see in the doc:

    @lisp
    (use-package foo
      :ensure-system-package foo)
    @end lisp

    This will expect a global binary package to exist called @code{foo}.

Should we use another name than "binary package"?  In my part of the
world these things are usually called "executables" or "programs",
occasionally they're called "binaries" but I'd never heard them called
"binary packages".



        Stefan






  reply	other threads:[~2022-12-09 14:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-09  0:11 bug#59914: [GNU ELPA] Make use-package and bind-key into :core packages Stefan Kangas
2022-12-09 14:56 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2022-12-12  2:37   ` Stefan Kangas
2022-12-12 14:56     ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-13  1:03       ` Stefan Kangas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvfsdo8wna.fsf-monnier+emacs@gnu.org \
    --to=bug-gnu-emacs@gnu.org \
    --cc=59914@debbugs.gnu.org \
    --cc=johnw@newartisans.com \
    --cc=monnier@iro.umontreal.ca \
    --cc=stefankangas@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).