From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#64232: 28.2; Incorrect(?) byte compilation warning about =?UTF-8?Q?=E2=80=98ansi-color-apply-on-region=E2=80=99?= Date: Wed, 28 Jun 2023 09:41:32 -0400 Message-ID: References: <874jmzs23h.wl-zack@owlfolio.org> <83o7l5yt9k.fsf@gnu.org> <9c38fe1a-ee3a-4b6d-aaa7-33aa4909e331@app.fastmail.com> <87jzvoe3qk.fsf@web.de> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32797"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , Zack Weinberg , 64232@debbugs.gnu.org To: Michael Heerdegen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jun 28 15:42:23 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qEVR8-0008I1-UG for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 28 Jun 2023 15:42:23 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qEVQs-0004W4-35; Wed, 28 Jun 2023 09:42:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qEVQo-0004Vh-Mt for bug-gnu-emacs@gnu.org; Wed, 28 Jun 2023 09:42:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qEVQo-000589-D8 for bug-gnu-emacs@gnu.org; Wed, 28 Jun 2023 09:42:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qEVQo-0007Mk-6C for bug-gnu-emacs@gnu.org; Wed, 28 Jun 2023 09:42:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 28 Jun 2023 13:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64232 X-GNU-PR-Package: emacs Original-Received: via spool by 64232-submit@debbugs.gnu.org id=B64232.168795970228279 (code B ref 64232); Wed, 28 Jun 2023 13:42:02 +0000 Original-Received: (at 64232) by debbugs.gnu.org; 28 Jun 2023 13:41:42 +0000 Original-Received: from localhost ([127.0.0.1]:50312 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qEVQT-0007M3-Iy for submit@debbugs.gnu.org; Wed, 28 Jun 2023 09:41:41 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:24631) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qEVQR-0007Lo-Pb for 64232@debbugs.gnu.org; Wed, 28 Jun 2023 09:41:40 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 75B8E80776; Wed, 28 Jun 2023 09:41:34 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 262B4805BA; Wed, 28 Jun 2023 09:41:33 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1687959693; bh=DxJG3Zuyid9qHnWkHYnc34XPSFZEnlcfQPaidyXTwgQ=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=pUe8BhAGaJvrfV6USogz5wowlVYVWtC7vVYl6Q9ZR6HkiQvkIylBCUTD07IRH8Ntf qNSQsHsK1FXgs9CbejwXM9IQfbQIjXcBzoRUEeck6eWu2N/qZNvvTZqNwbH3yJ522/ 10ZNMbErgbmoMpZL5QPM6KkJQNcVRmnyyZlcGGaOGM+jog0tJbEYs3HsTkkcUlJoOz Yx1K1THXN0endNs4JKAD/FW072JQVuoqRHC68jVcITpa1PMwgtudkfWE+cabbqhxjH 7bjgUgnl4r4rMKx0iHw7g5Za4H5Czvu2JTwRy2zvVxiVmnhzN/4HOk9K6GCBNpsUAQ NMkU3b+XdzuaA== Original-Received: from pastel (69-165-155-162.dsl.teksavvy.com [69.165.155.162]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id F25CB120306; Wed, 28 Jun 2023 09:41:32 -0400 (EDT) In-Reply-To: <87jzvoe3qk.fsf@web.de> (Michael Heerdegen's message of "Wed, 28 Jun 2023 04:10:27 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:264221 Archived-At: > diff --git a/lisp/emacs-lisp/bytecomp.el b/lisp/emacs-lisp/bytecomp.el > index 99202185d8d..f468e34bb42 100644 > --- a/lisp/emacs-lisp/bytecomp.el > +++ b/lisp/emacs-lisp/bytecomp.el > @@ -554,7 +554,9 @@ byte-compile-initial-macro-environment > (let ((byte-compile-unresolved-functions > byte-compile-unresolved-functions) > (byte-compile-new-defuns > - byte-compile-new-defuns)) > + byte-compile-new-defuns) > + (byte-compile-noruntime-functions > + byte-compile-noruntime-functions)) > (setf result > (byte-compile-eval > (byte-run-strip-symbol-positions Hmm... this doesn't look right: one of the main purpose of `byte-compile-eval` is (beside calling `eval`) to populate `byte-compile-noruntime-functions`, so if you let-bind it around the call, it's like calling `eval` and we can just get rid of `byte-compile-noruntime-functions` altogether. The "natural" place to put the let-binding would be in `byte-compile-close-variables` (assuming it still fixes the bug). Stefan