From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#64596: 30.0.50; On FIXME: in src/buffer.c:1481 (force-mode-line-update) Date: Sun, 16 Jul 2023 14:53:03 -0400 Message-ID: References: <877cr4nez9.fsf@localhost> <83lefj4okb.fsf@gnu.org> <83fs5r3tqv.fsf@gnu.org> <834jm6fppc.fsf@gnu.org> <87a5vyidy6.fsf@localhost> <83sf9qe2ip.fsf@gnu.org> <83a5vxejz6.fsf@gnu.org> <87ttu4gnpt.fsf@localhost> <83351o9m6h.fsf@gnu.org> <87ilakgmjo.fsf@localhost> <83pm4r9apt.fsf@gnu.org> <83mszv93yb.fsf@gnu.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4008"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: yantar92@posteo.net, 64596@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jul 16 20:54:17 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qL6sq-0000oq-RN for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 16 Jul 2023 20:54:17 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qL6sd-0000Zy-HW; Sun, 16 Jul 2023 14:54:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qL6sc-0000Yg-0O for bug-gnu-emacs@gnu.org; Sun, 16 Jul 2023 14:54:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qL6sb-0006St-O2 for bug-gnu-emacs@gnu.org; Sun, 16 Jul 2023 14:54:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qL6sb-0001PN-Jo for bug-gnu-emacs@gnu.org; Sun, 16 Jul 2023 14:54:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 16 Jul 2023 18:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64596 X-GNU-PR-Package: emacs Original-Received: via spool by 64596-submit@debbugs.gnu.org id=B64596.16895335935355 (code B ref 64596); Sun, 16 Jul 2023 18:54:01 +0000 Original-Received: (at 64596) by debbugs.gnu.org; 16 Jul 2023 18:53:13 +0000 Original-Received: from localhost ([127.0.0.1]:48578 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qL6ro-0001OJ-TD for submit@debbugs.gnu.org; Sun, 16 Jul 2023 14:53:13 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:54614) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qL6rm-0001O5-J6 for 64596@debbugs.gnu.org; Sun, 16 Jul 2023 14:53:11 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 10EAC803B1; Sun, 16 Jul 2023 14:53:05 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id EBAA780057; Sun, 16 Jul 2023 14:53:03 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1689533584; bh=yKmtTpMO3CJ5SfUn6QmpjwHQQ7wevZzWwIvBpf2mSj8=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=agMPKG4pnAGYaEa3CaNxGjA05GRAXxVdNNmX0NfRaASlBd47a2a9naXL1t4SZMnbu efrwl99hbFFxVb3K13lnKI2M6u+fbOJCV0NaEpPvH5hKKxv1kPCcdpznj/Zz+abrBY FGvQ1NoUbJnBj/InDfg5NjIbpRVA92NKvIz+F8eR1RymB/a+yKDDxjkl8ijU9Rjowm XMNMvkBLRHY1FS08vOMVo/6K/BWqGLZWqbAzyPkQq8iVRdlvMnLm76iiyvelNNy82r AaRo8oM41zwxeE79Ur+cL61p+8vSoYjwCGb9I3PWPj2TJfyZIbzkANDkdPxv1RV6Q3 h4Y/ZuJtTEmOw== Original-Received: from pastel (unknown [108.175.226.218]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id BF59D12031C; Sun, 16 Jul 2023 14:53:03 -0400 (EDT) In-Reply-To: <83mszv93yb.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 16 Jul 2023 20:11:24 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:265358 Archived-At: >> Hmm... I'm not sure why you're saying >> >> frame's redisplay flag is what causes us to consider a frame in the >> first place. > > Because fset_redisplay does this: > > void > fset_redisplay (struct frame *f) > { > redisplay_other_windows (); > f->redisplay = true; > } > > and redisplay_other_windows sets windows_or_buffers_changed, which > then causes consider_all_windows_p to be true upon the next redisplay > cycle: > > consider_all_windows_p = (update_mode_lines > || windows_or_buffers_changed); Yes, most calls to `[fbw]set_redisplay` will call `redisplay_other_windows` and once that function has been called, all the frames will be "considered", but that happens regardless of the `redisplay` bit of any particular frame. The `redisplay` bit is consulted later, once we loop over all the windows in all those frames, where we decide which of those windows are updated depending on the `redisplay` bits of the window, the window's buffer, and the window's frame. Are you maybe confused by the name of the `FRAME_REDISPLAY_P` macro, which does *not* pay attention to the `redisplay` bit? > IOW, this is not just a matter of exposing a small number of functions > to Lisp, IMO. I'm sorry if I made you think I suggested it would be a simple matter. Stefan