From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#65414: save-some-buffers-functions are unexpectedly called when save-some-buffers pred is non-nil Date: Sun, 03 Sep 2023 13:06:07 -0400 Message-ID: References: <871qfxvvw9.fsf@breatheoutbreathe.in> <83lee4vcac.fsf@gnu.org> <87o7ixe1e2.fsf@breatheoutbreathe.in> <83o7ixqatx.fsf@gnu.org> <87fs46cn6u.fsf@breatheoutbreathe.in> <838r9ymfh5.fsf@gnu.org> <874jkmck9j.fsf@breatheoutbreathe.in> <83v8ct9gmg.fsf@gnu.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18907"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: jonas@bernoul.li, 65414@debbugs.gnu.org, Joseph Turner To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Sep 03 19:17:18 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qcqir-0004hr-NV for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 03 Sep 2023 19:17:17 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qcqih-0005ck-Gp; Sun, 03 Sep 2023 13:17:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qcqid-0005cH-D0 for bug-gnu-emacs@gnu.org; Sun, 03 Sep 2023 13:17:06 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qcqid-0001ss-4Q for bug-gnu-emacs@gnu.org; Sun, 03 Sep 2023 13:17:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qcqic-0000RZ-GV for bug-gnu-emacs@gnu.org; Sun, 03 Sep 2023 13:17:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 03 Sep 2023 17:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65414 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 65414-submit@debbugs.gnu.org id=B65414.16937613921665 (code B ref 65414); Sun, 03 Sep 2023 17:17:02 +0000 Original-Received: (at 65414) by debbugs.gnu.org; 3 Sep 2023 17:16:32 +0000 Original-Received: from localhost ([127.0.0.1]:46738 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcqi7-0000Qn-VC for submit@debbugs.gnu.org; Sun, 03 Sep 2023 13:16:32 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:56638) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcqi5-0000QZ-4w for 65414@debbugs.gnu.org; Sun, 03 Sep 2023 13:16:29 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 11845100068; Sun, 3 Sep 2023 13:06:16 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1693760775; bh=w1mS7Dihp6l4c3a4KeyXSV9QF7XiE5cZTOqgrUJR0rA=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=h3XcGwqTSh7eq3TDP2mKCWotdPTf80wsA9yD8N56ip1T4orBYu+uK8xIeTXMbh5o4 xLryV/nnUm1Mo2y0ErHCYsG4xDudCFKLvnStav6xq+RhuWA+TqfhuSSm260QqPoTx/ 1jlF5loe20VXZ37FRzRLAO7PBYqbL9h8ASzPLzm9f1v+M29EIHb6j9ir2ixsnkKNlR L4ZoRmhtRNnbLmU0OWJiLBBQm0mHiL52mYCQARHZIFSEJY+ehRu3qPszZQEWe3Is9h F7Ke2Gcj7A7Fmdk8kR/89pAHLdO+I5plAQovcRpsieeNIKU7euJxTFG7w7jhQwyxE9 bnw2l0x5yyA0w== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 02A22100046; Sun, 3 Sep 2023 13:06:15 -0400 (EDT) Original-Received: from pastel (104-222-114-42.cpe.teksavvy.com [104.222.114.42]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id B528B12022A; Sun, 3 Sep 2023 13:06:14 -0400 (EDT) In-Reply-To: <83v8ct9gmg.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 02 Sep 2023 10:30:31 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:269171 Archived-At: >> > In any case, not calling save-some-buffers-functions when PRED is >> > non-nil is not something we can do, as that would be an incompatible >> > behavior change. We could perhaps add PRED to the arguments with >> > which save-some-buffers-functions are called, as an optional argument. >> > Would that be satisfactory? >> Yes, that would solve the interference between Magit and hyperdrive.el. >> See patch. [ Sorry, `debbugs.gnu.org` appears to be down, so I couldn't read the whole bug report, so I haven't seen the patch among other things. Hopefully that doesn't invalidate my comment :-) ] > Hmm... but how to make this change backward-compatible? I mean, if > there's some function out there that is used in > save-some-buffers-functions, and it was written to accept only 2 > arguments, we cannot safely call it with 3 arguments, can we? AFAICT `save-some-buffers-functions` is brand new in Emacs-29.1 and currently gets called sometimes with 1 and sometimes with 2 arguments (that's a somewhat unusual API in this respect), so it's probably OK to break backward compatibility because it will only affect fresh code that can easily be adjusted. [ Arguably, it would be even better to arrange for `hyperdrive.el` to save its buffers "in the usual way", i.e. relying on `buffer-offer-save`, `save-buffer`, `buffer-save-without-query, ... ] Stefan