From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#71123: [PATCH] Rename `subr-native-elisp` to `native-comp-function` Date: Fri, 24 May 2024 09:07:23 -0400 Message-ID: References: Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22182"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 71123@debbugs.gnu.org To: Andrea Corallo Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri May 24 15:08:21 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sAUeh-0005V3-UO for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 24 May 2024 15:08:20 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sAUeN-0004Ui-Ac; Fri, 24 May 2024 09:07:59 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sAUeK-0004UA-AQ for bug-gnu-emacs@gnu.org; Fri, 24 May 2024 09:07:56 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sAUeK-0003F7-0w for bug-gnu-emacs@gnu.org; Fri, 24 May 2024 09:07:56 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sAUeQ-0007qM-Ib for bug-gnu-emacs@gnu.org; Fri, 24 May 2024 09:08:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 24 May 2024 13:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71123 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 71123-submit@debbugs.gnu.org id=B71123.171655606130135 (code B ref 71123); Fri, 24 May 2024 13:08:02 +0000 Original-Received: (at 71123) by debbugs.gnu.org; 24 May 2024 13:07:41 +0000 Original-Received: from localhost ([127.0.0.1]:37097 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sAUe4-0007pz-P6 for submit@debbugs.gnu.org; Fri, 24 May 2024 09:07:40 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:47972) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sAUe3-0007pt-G8 for 71123@debbugs.gnu.org; Fri, 24 May 2024 09:07:39 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 8EF8C4423F2; Fri, 24 May 2024 09:07:26 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1716556045; bh=C8hCqFI9Tgl/wM65dt0LZpq7Kd9JVIEppmQ+2LJcIoA=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=QWFYDIhT9kCHQKAj0txHZav2PXY88aupsIuqWkjZRO5X0NXoalmx9n7JOjMzPOW6r +zDfwmrDuq/9oxcqDi+5ZrRQF2eQoaGSiJTF+DlZ4UnwXIwxEOreFjSErGTcKE4D10 5rKN4oTpMka7oD2FM+/IOi7ZVt1JKHTJq73vOJ0luNX6CEgbDSCX5TcL7a7YjAWlKZ Mvs77maWsKwXtKg661L0wHs2/57fjv7BCTK0WnM7RP9if9YQagVe/rFQaMlLEZRMDd jGd8vy5WPR3X2C9tEce82kMW+SnrW1bQIr1zrk4uC/cyjyBu1Bz9eLSaJkl14+nYXw EAlbz5ytGnxqw== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 44FCC4423DD; Fri, 24 May 2024 09:07:25 -0400 (EDT) Original-Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 35C291204F5; Fri, 24 May 2024 09:07:25 -0400 (EDT) In-Reply-To: (Andrea Corallo's message of "Fri, 24 May 2024 03:17:30 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:285770 Archived-At: > On the patch itself I've three comments: > > - If we go for it, shouldn't we rename SUBR_NATIVE_COMPILEDP and > SUBR_NATIVE_COMPILED_DYNP macros as well for consistency? No opinion on this. Eli? > - The patch introduces a number of warnings in: help-fns.el, subr.el, > bytecomp.el, comp.el, comp-common.el. > - It's also introducing a fail in lisp/help-fns-tests.log AFAIK these were fixed by the second patch. Do you still see them after installing the two patches? Stefan