From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Andrea Corallo <acorallo@gnu.org>
Cc: 71123@debbugs.gnu.org
Subject: bug#71123: [PATCH] Rename `subr-native-elisp` to `native-comp-function`
Date: Fri, 24 May 2024 09:07:23 -0400 [thread overview]
Message-ID: <jwvfru72wca.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <yp1ikz3y8z9.fsf@fencepost.gnu.org> (Andrea Corallo's message of "Fri, 24 May 2024 03:17:30 -0400")
> On the patch itself I've three comments:
>
> - If we go for it, shouldn't we rename SUBR_NATIVE_COMPILEDP and
> SUBR_NATIVE_COMPILED_DYNP macros as well for consistency?
No opinion on this. Eli?
> - The patch introduces a number of warnings in: help-fns.el, subr.el,
> bytecomp.el, comp.el, comp-common.el.
> - It's also introducing a fail in lisp/help-fns-tests.log
AFAIK these were fixed by the second patch.
Do you still see them after installing the two patches?
Stefan
next prev parent reply other threads:[~2024-05-24 13:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-22 17:50 bug#71123: [PATCH] Rename `subr-native-elisp` to `native-comp-function` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-22 18:47 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-24 7:17 ` Andrea Corallo
2024-05-24 7:37 ` Eli Zaretskii
2024-05-24 13:07 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2024-05-24 14:46 ` Eli Zaretskii
2024-05-25 7:16 ` Andrea Corallo
2024-05-28 19:35 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-28 19:58 ` Andrea Corallo
2024-05-29 0:53 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvfru72wca.fsf-monnier+emacs@gnu.org \
--to=bug-gnu-emacs@gnu.org \
--cc=71123@debbugs.gnu.org \
--cc=acorallo@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).