From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#2151: 23.0.90; Building the 23.0.90 pretest recompiles Lisp files Date: Sat, 21 Feb 2009 15:54:01 -0500 Message-ID: References: Reply-To: Stefan Monnier , 2151@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1235250305 29519 80.91.229.12 (21 Feb 2009 21:05:05 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 21 Feb 2009 21:05:05 +0000 (UTC) Cc: 2151@emacsbugs.donarmstrong.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Feb 21 22:06:21 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Laz22-000192-8R for geb-bug-gnu-emacs@m.gmane.org; Sat, 21 Feb 2009 22:05:08 +0100 Original-Received: from localhost ([127.0.0.1]:35527 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Laz0h-0001s1-WA for geb-bug-gnu-emacs@m.gmane.org; Sat, 21 Feb 2009 16:03:44 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Laz0d-0001rj-Sk for bug-gnu-emacs@gnu.org; Sat, 21 Feb 2009 16:03:39 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Laz0d-0001rT-7m for bug-gnu-emacs@gnu.org; Sat, 21 Feb 2009 16:03:39 -0500 Original-Received: from [199.232.76.173] (port=37219 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Laz0d-0001rJ-2U for bug-gnu-emacs@gnu.org; Sat, 21 Feb 2009 16:03:39 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:50052) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Laz0c-0005R2-CM for bug-gnu-emacs@gnu.org; Sat, 21 Feb 2009 16:03:38 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n1LL3aMh023296; Sat, 21 Feb 2009 13:03:36 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id n1LL02vM022158; Sat, 21 Feb 2009 13:00:02 -0800 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Stefan Monnier Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Sat, 21 Feb 2009 21:00:02 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 2151 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 2151-submit@emacsbugs.donarmstrong.com id=B2151.123524965120886 (code B ref 2151); Sat, 21 Feb 2009 21:00:02 +0000 Original-Received: (at 2151) by emacsbugs.donarmstrong.com; 21 Feb 2009 20:54:11 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from ironport2-out.teksavvy.com (ironport2-out.pppoe.ca [206.248.154.182]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n1LKs75P020878 for <2151@emacsbugs.donarmstrong.com>; Sat, 21 Feb 2009 12:54:08 -0800 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AmQFAC/5n0lLd+0i/2dsb2JhbACBbdF9hA8Gg1A X-IronPort-AV: E=Sophos;i="4.38,246,1233550800"; d="scan'208";a="34192141" Original-Received: from 75-119-237-34.dsl.teksavvy.com (HELO pastel.home) ([75.119.237.34]) by ironport2-out.teksavvy.com with ESMTP; 21 Feb 2009 15:54:01 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 2BF254B488; Sat, 21 Feb 2009 15:54:01 -0500 (EST) In-Reply-To: (Eli Zaretskii's message of "Sat, 21 Feb 2009 18:10:47 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.90 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Sat, 21 Feb 2009 16:03:39 -0500 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:25567 Archived-At: >> >> > We could add some file to the tarball, generated at make-dist time, to >> >> > signal that bootstrap-emacs is not needed. That file could actually >> >> > be named `bootstrap-emacs', which should resolve the problem nicely >> >> > (assuming we manage to have it older than the oldest .elc file). >> >> Maybe we can get that to work, but it sounds terribly hackish. >> > Why hackish? many distributions have or create such time-stamp files, >> > for Make's sake. >> >> I guess it depends on the details. > After thinking some more about this, I don't see any easy and safe > solution besides adding a "bootstrap-emacs" file to the tarball. > Maybe in future releases we will be able to find a better way, but for > now this is the only one that's safe. > I will do that if you agree. I'd rather not if the patch I suggested works. Does it? > In any case, it sounds wrong to me to have the distribution biased in > favor of people who build Emacs out of CVS. My guess is that many more people build from CVS than from the release tarball. Most users of the release will use a precompiled package. So I care much more about building from CVS than building from a tarball. Also I care more about the build being reliable and maintainable, than about it being optimal in all circumstances, so if building from the tarball does a bit of extra work, I don't really mind as long as it makes maintenance easier. I do think the patch I proposed fixes the problem and doesn't make the code significantly more hairy, so I'm willing to install it. I've been using it ever since I sent it and it seems to work fine (tho I basically never boostrap anyway), but I'd like confirmation that it fixes your problem before installing it. >> >> Also, I'd like to make sure that if some wants to change some .el files >> >> and then recompile, it still works correctly. >> > It will, I think, because we can copy emacs to bootstrap-emacs at the >> > end of the build. >> What if they edit .el files before building a first `emacs'? > We could arrange for byte-recompile-directory at the end of the build, > if that is a real-life use-case. That wouldn't help: the problem is that such a change would trigger recompilation of the .elc file, which in turn will run your dummy bootstrap-emacs, at which point the build will presumably fail. Stefan