From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Jorgen Schaefer <forcer@forcix.cx>
Cc: 12619@debbugs.gnu.org
Subject: bug#12619: completion-at-point and changing buffer
Date: Wed, 24 Oct 2012 13:48:33 -0400 [thread overview]
Message-ID: <jwvehkng3w1.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <20121024183546.77834f77@forcix.kollektiv-hamburg.de>
>> I've just installed a patch which should solve those problems.
>> Can you confirm it fixes your case?
> I'm afraid it doesn't (tested with trunk/110646). The problem is that
> `minibuffer-force-complete' uses `field-beginning' and `field-end',
> neither of which returns a marker. So even if the original function
> uses markers, at this point they are turned into absolute buffer
> positions.
> Wrapping both calls in `copy-marker' fixes the problem for me.
You mean the patch below?
I guess you're right, it's still needed for the use of `start' in:
(lambda () "Cycle through the possible completions."
(interactive)
(let ((completion-extra-properties extra-prop))
(completion-in-region start (point) table pred)))))
Can you confirm that this patch fixes it?
Stefan
=== modified file 'lisp/minibuffer.el'
--- lisp/minibuffer.el 2012-10-24 03:22:21 +0000
+++ lisp/minibuffer.el 2012-10-24 17:47:17 +0000
@@ -1114,7 +1114,7 @@
;; FIXME: Need to deal with the extra-size issue here as well.
;; FIXME: ~/src/emacs/t<M-TAB>/lisp/minibuffer.el completes to
;; ~/src/emacs/trunk/ and throws away lisp/minibuffer.el.
- (let* ((start (field-beginning))
+ (let* ((start (copy-marker (field-beginning)))
(end (field-end))
;; (md (completion--field-metadata start))
(all (completion-all-sorted-completions))
next prev parent reply other threads:[~2012-10-24 17:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-10 19:39 bug#12619: completion-at-point and changing buffer Jorgen Schaefer
2012-10-11 0:37 ` Stefan Monnier
2012-10-11 18:19 ` Jorgen Schaefer
2012-10-24 3:19 ` Stefan Monnier
2012-10-24 16:35 ` Jorgen Schaefer
2012-10-24 17:48 ` Stefan Monnier [this message]
2012-10-24 18:58 ` Jorgen Schaefer
2012-10-24 19:40 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvehkng3w1.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=12619@debbugs.gnu.org \
--cc=forcer@forcix.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).