From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Stephen Berman <stephen.berman@gmx.net>
Cc: 14702@debbugs.gnu.org
Subject: bug#14702: 24.3.50; Byte-compiling called-interactively-p inside catch
Date: Mon, 24 Jun 2013 21:39:21 -0400 [thread overview]
Message-ID: <jwvehbrc6si.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87zjufd1ks.fsf@rosalinde.fritz.box> (Stephen Berman's message of "Mon, 24 Jun 2013 16:29:23 +0200")
> (defun baz ()
> (interactive)
> (catch 'test
> (if (called-interactively-p 'any)
If it hurts, don't do that.
Internally, the byte-compiled form of catch ends up wrapping its body
inside a lambda, so the called-interactively-p test refers to the
implicit lambda added, rather than to the enclosing function
you defined.
It would be good to avoid this intermediate lambda for performance
reasons (which would incidentally also fix this particular issue), but
in the mean time (and more generally) either avoid
called-interactively-p (pass an extra argument instead), or avoid
placing it "deep" within your function (e.g. inside
a catch/unwind-protect/condition-case/save-foobar/...).
Stefan
next prev parent reply other threads:[~2013-06-25 1:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-24 14:29 bug#14702: 24.3.50; Byte-compiling called-interactively-p inside catch Stephen Berman
2013-06-25 1:39 ` Stefan Monnier [this message]
2013-06-25 13:56 ` Stephen Berman
2013-06-25 14:04 ` Stefan Monnier
2013-06-25 14:18 ` Stephen Berman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvehbrc6si.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=14702@debbugs.gnu.org \
--cc=stephen.berman@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).