From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#3984: Date: Fri, 20 Sep 2013 10:54:05 -0400 Message-ID: References: <20E00C7675E64356BF2F0B2A7E0ABDB1@us.oracle.com> <5232D333.8030206@thompsonclan.org> <523359CD.2070904@thompsonclan.org> <5233670E.4030703@thompsonclan.org> <5237C9FF.1000809@thompsonclan.org> <52388FEB.6020007@thompsonclan.org> <523A37A4.5060505@thompsonclan.org> <523A49BE.3060109@thompsonclan.org> <523AB06B.9090606@thompsonclan.org> <523B4F4E.3060204@thompsonclan.org> <523B73CF.4080105@thompsonclan.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1379688920 8822 80.91.229.3 (20 Sep 2013 14:55:20 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 20 Sep 2013 14:55:20 +0000 (UTC) Cc: 3984@debbugs.gnu.org To: Ryan Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Sep 20 16:55:23 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VN277-0006vj-Ai for geb-bug-gnu-emacs@m.gmane.org; Fri, 20 Sep 2013 16:55:21 +0200 Original-Received: from localhost ([::1]:56228 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VN277-00069a-0F for geb-bug-gnu-emacs@m.gmane.org; Fri, 20 Sep 2013 10:55:21 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49405) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VN26w-00069F-RA for bug-gnu-emacs@gnu.org; Fri, 20 Sep 2013 10:55:18 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VN26p-0003Gz-9B for bug-gnu-emacs@gnu.org; Fri, 20 Sep 2013 10:55:10 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:42996) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VN26p-0003Fm-6A for bug-gnu-emacs@gnu.org; Fri, 20 Sep 2013 10:55:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1VN26o-00076t-Lu for bug-gnu-emacs@gnu.org; Fri, 20 Sep 2013 10:55:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 20 Sep 2013 14:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 3984 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 3984-submit@debbugs.gnu.org id=B3984.137968886327285 (code B ref 3984); Fri, 20 Sep 2013 14:55:02 +0000 Original-Received: (at 3984) by debbugs.gnu.org; 20 Sep 2013 14:54:23 +0000 Original-Received: from localhost ([127.0.0.1]:51288 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VN26A-000760-LL for submit@debbugs.gnu.org; Fri, 20 Sep 2013 10:54:22 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:14842) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VN260-00075a-13 for 3984@debbugs.gnu.org; Fri, 20 Sep 2013 10:54:13 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av4EABK/CFFFpY2x/2dsb2JhbABEvw4Xc4IeAQEEAVYjBQsLNBIUGA0kiB4GwS2RCgOkeoFegxM X-IPAS-Result: Av4EABK/CFFFpY2x/2dsb2JhbABEvw4Xc4IeAQEEAVYjBQsLNBIUGA0kiB4GwS2RCgOkeoFegxM X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="28463870" Original-Received: from 69-165-141-177.dsl.teksavvy.com (HELO pastel.home) ([69.165.141.177]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 20 Sep 2013 10:50:08 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 69C1F63186; Fri, 20 Sep 2013 10:54:05 -0400 (EDT) In-Reply-To: <523B73CF.4080105@thompsonclan.org> (Ryan's message of "Thu, 19 Sep 2013 14:59:43 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:78609 Archived-At: > Ok, I have written a couple of tests, two of which are currently failing > (mine are the ones with numbered suffixes 2 through 5). I am > attaching a patch that adds these tests. ERT output is below: Thanks. Just a few questions, before installing the patch. > +(defun clear-advice (symbol) > + "Reset SYMBOL's function to its original unadvised definition." > + (let ((func (symbol-function symbol))) > + (while (advice--p func) > + (setq func (advice--cdr func))) > + (fset symbol func))) Why do you need that? AFAICT you only use it after defining sm-test7.2, and I don't see why that call is needed. > +(defmacro post-restore-func (func &rest body) > + (let ((fdef (symbol-function func))) > + `(unwind-protect > + (progn ,@body) > + (fset ',func ,fdef)))) > +(put 'post-restore-func 'lisp-indent-function > + (get 'prog1 'lisp-indent-function)) Since it's only used once, I don't think it's worth defining a macro for it. Stefan